[ENH] Proposal for inclusion - Hierarchy List Morph - Navigation ( [et] looks groovy! any SUnit tests? )
< I'm a bug-fixing machine! >
This post brought to you by the BugFixArchiveViewer, a handy tool that makes it easy to comment on proposed fixes and enhancements for Squeak. For more information, check out the Web page for the BugFixArchiveViewer project: http://minnow.cc.gatech.edu/squeak/3214
< I'm a bug-fixing machine! >
I've got both changesets loaded (in an otherwise vanilla image AFAICT), and the ObjectExplorer blows up on a yellow-button click when no tree element is selected, with the following error:
VM: unix - Squeak3.4 of 1 March 2003 [latest update: #5170] Image: Squeak3.6beta [latest update: #5373]
SmallInteger(Object)>>doesNotUnderstand: #parent Receiver: 1 Arguments and temporary variables: aMessage: a Message with selector: #parent and arguments: #() Receiver's instance variables: 1
ObjectExplorer>>parentObject Receiver: an ObjectExplorer Arguments and temporary variables:
Receiver's instance variables: dependents: #(a SystemWindow(1828) a SimpleHierarchicalListMorph(526) a Pluggab...etc... currentSelection: 1 myBrowser: nil rootObject: a BugFixArchiveViewer(3753) inspector: nil monitorList: nil
ObjectExplorer>>genericMenu: Receiver: an ObjectExplorer Arguments and temporary variables: aMenu: a MenuMorph(1083) insideObject: 1 menu: nil parentObject: nil i: nil Receiver's instance variables: dependents: #(a SystemWindow(1828) a SimpleHierarchicalListMorph(526) a Pluggab...etc... currentSelection: 1 myBrowser: nil rootObject: a BugFixArchiveViewer(3753) inspector: nil monitorList: nil
< I'm a bug-fixing machine! >
This post brought to you by the BugFixArchiveViewer, a handy tool that makes it easy to comment on proposed fixes and enhancements for Squeak. For more information, check out the Web page for the BugFixArchiveViewer project: http://minnow.cc.gatech.edu/squeak/3214
< I'm a bug-fixing machine! >
On Friday 25 July 2003 04:24 pm, brentvukmer@yahoo.com wrote:
I've got both changesets loaded (in an otherwise vanilla image AFAICT), and the ObjectExplorer blows up on a yellow-button click when no tree element is selected, with the following error:
You can see the same problem (without the walkback) with just the HLM-Navigation loaded: open an Object Explorer and do a yellow-button click without selecting anything.
What *should* happen is that you should see a menu with a single item '*nothing selected*'. However, the Object Explorer is convinced that its current selection is 1. It should be nil.
The reason it blows up with my change set is that I'm not looking for anything other than nil or an ObjectExplorerWrapper, since these are the only things that the model's current selection should be set to.
This is because of the incorrect change to AbstractHierarchicalList>>getCurrentSelection, where he's no longer returning a nil when there is no selection. Perhaps this is because of confusion between the Morphic side (where we're dealing with selection indexes) and the model side (where we're dealing with model items).
If you revert that method change, you'll see the walkback go away.
squeak-dev@lists.squeakfoundation.org
-
brentvukmer＠yahoo.com -
bvukmer＠blackboard.com -
Ned Konz