Hi all, while using Preferences window I found out that clicking on Help button was not working due to a missing check on emptyness of a string. here is the fix for 3.8:
<<PreferencesHelpFix.1.cs>> --- Enrico Spinielli Eurocontrol/CFMU enrico.spinielli at eurocontrol.int office 21.111 tel:+32-2-7299716 Rue de la Fusée, 96 fax:+32-2-7299022 B-1130 BruxellesBelgium
____
This message and any files transmitted with it are legally privileged and intended for the sole use of the individual(s) or entity to whom they are addressed. If you are not the intended recipient, please notify the sender by reply and delete the message and any attachments from your system. Any unauthorised use or disclosure of the content of this message is strictly prohibited and may be unlawful.
Nothing in this e-mail message amounts to a contractual or legal commitment on the part of EUROCONTROL unless it is confirmed by appropriately signed hard copy.
Any views expressed in this message are those of the sender.
On 8/31/05, SPINIELLI Enrico enrico.spinielli@eurocontrol.int wrote:
while using Preferences window I found out that clicking on Help button was not working due to a missing check on emptyness of a string. here is the fix for 3.8:
Good catch. You seem to have replaced this line:
(aHelpString last == $.) ifFalse: [aStream nextPut: $.].
with this one:
(aHelpString isEmpty not and: [aHelpString last == $.]) ifFalse: [aStream nextPut: $.].
(I've reformatted these to have the same form and to fit to e-mail width.) But the original had the intent of putting a period at the end of the help message, if it didn't end with one. The new line will put a period at the end of an empty help message. That seems undesirable. Perhaps this is more like what's intended:
(aHelpString notEmpty and: [aHelpString last ~~ $.]) ifTrue: [aStream nextPut: $.].
Cheers!
--Tom Phoenix
thanks normally in 3.9 we will use the new preferences browser developed by hernan. So if you want to try on 3.9a and give feedback this can help him.
Stef
On 31 août 05, at 18:11, SPINIELLI Enrico wrote:
Hi all, while using Preferences window I found out that clicking on Help button was not working due to a missing check on emptyness of a string. here is the fix for 3.8:
<<PreferencesHelpFix.1.cs>>
Enrico Spinielli Eurocontrol/CFMU enrico.spinielli at eurocontrol.int office 21.111 tel:+32-2-7299716 Rue de la Fusée, 96 fax:+32-2-7299022 B-1130 BruxellesBelgium
This message and any files transmitted with it are legally privileged and intended for the sole use of the individual(s) or entity to whom they are addressed. If you are not the intended recipient, please notify the sender by reply and delete the message and any attachments from your system. Any unauthorised use or disclosure of the content of this message is strictly prohibited and may be unlawful.
Nothing in this e-mail message amounts to a contractual or legal commitment on the part of EUROCONTROL unless it is confirmed by appropriately signed hard copy.
Any views expressed in this message are those of the sender.
<PreferencesHelpFix.1.cs>
Thank you for your report. I have transfered your report to Squeak's Mantis Database and you can followup on the issue if desired by going to http://bugs.impara.de/view.php?id=1766 .
In the future please report new issues on Squeak's Mantis Database at
Thanks!
On August 31, 2005 12:11, SPINIELLI Enrico wrote:
Hi all, while using Preferences window I found out that clicking on Help button was not working due to a missing check on emptyness of a string. here is the fix for 3.8:
<<PreferencesHelpFix.1.cs>>
Enrico Spinielli Eurocontrol/CFMU enrico.spinielli at eurocontrol.int office 21.111 tel:+32-2-7299716 Rue de la Fusée, 96 fax:+32-2-7299022 B-1130 BruxellesBelgium
This message and any files transmitted with it are legally privileged and intended for the sole use of the individual(s) or entity to whom they are addressed. If you are not the intended recipient, please notify the sender by reply and delete the message and any attachments from your system. Any unauthorised use or disclosure of the content of this message is strictly prohibited and may be unlawful.
Nothing in this e-mail message amounts to a contractual or legal commitment on the part of EUROCONTROL unless it is confirmed by appropriately signed hard copy.
Any views expressed in this message are those of the sender.
Thank you for your report. I have transfered your report to Squeak's Mantis Database and you can followup on the issue if desired by going to http://bugs.impara.de/view.php?id=1766 .
In the future please report new issues on Squeak's Mantis Database at
Thanks!
PS: this is a repetition with a header set correctly as described in the janitors Task 1. I appologize for the repetition.
On August 31, 2005 12:11, SPINIELLI Enrico wrote:
Hi all, while using Preferences window I found out that clicking on Help button was not working due to a missing check on emptyness of a string. here is the fix for 3.8:
<<PreferencesHelpFix.1.cs>>
Enrico Spinielli Eurocontrol/CFMU enrico.spinielli at eurocontrol.int office 21.111 tel:+32-2-7299716 Rue de la Fusée, 96 fax:+32-2-7299022 B-1130 BruxellesBelgium
This message and any files transmitted with it are legally privileged and intended for the sole use of the individual(s) or entity to whom they are addressed. If you are not the intended recipient, please notify the sender by reply and delete the message and any attachments from your system. Any unauthorised use or disclosure of the content of this message is strictly prohibited and may be unlawful.
Nothing in this e-mail message amounts to a contractual or legal commitment on the part of EUROCONTROL unless it is confirmed by appropriately signed hard copy.
Any views expressed in this message are those of the sender.
squeak-dev@lists.squeakfoundation.org