Eliot Miranda uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-eem.1597.mcz
==================== Summary ====================
Name: Morphic-eem.1597 Author: eem Time: 30 November 2019, 7:05:24.872005 pm UUID: 068e0786-10ca-433e-9ec1-7c5cc2a15942 Ancestors: Morphic-eem.1596
Fix regression from hurried programming. Apologies!
=============== Diff against Morphic-eem.1596 ===============
Item was added: + ----- Method: TextEditor>>selectedLiteral (in category 'menu messages') ----- + selectedLiteral + "Try to make a literal out of the current text selection" + | tokens | + tokens := Scanner new typedScanTokens: self selection string. + ^tokens isEmpty ifFalse: [tokens first]!
Item was changed: ----- Method: TextEditor>>selectedSelector (in category 'menu messages') ----- selectedSelector "Try to make a selector out of the current text selection" + ^self selection string findSelector! - | tokens | - tokens := Scanner new typedScanTokens: self selection string. - ^tokens isEmpty ifFalse: [tokens first]!
Hi Eliot,
can you give an example string that would match #selectedLiteral but not #selectedSelector? Once I can understand this change, I can write some tests for it. :-)
Best, Marcel Am 01.12.2019 04:05:43 schrieb commits@source.squeak.org commits@source.squeak.org: Eliot Miranda uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-eem.1597.mcz
==================== Summary ====================
Name: Morphic-eem.1597 Author: eem Time: 30 November 2019, 7:05:24.872005 pm UUID: 068e0786-10ca-433e-9ec1-7c5cc2a15942 Ancestors: Morphic-eem.1596
Fix regression from hurried programming. Apologies!
=============== Diff against Morphic-eem.1596 ===============
Item was added: + ----- Method: TextEditor>>selectedLiteral (in category 'menu messages') ----- + selectedLiteral + "Try to make a literal out of the current text selection" + | tokens | + tokens := Scanner new typedScanTokens: self selection string. + ^tokens isEmpty ifFalse: [tokens first]!
Item was changed: ----- Method: TextEditor>>selectedSelector (in category 'menu messages') ----- selectedSelector "Try to make a selector out of the current text selection" + ^self selection string findSelector! - | tokens | - tokens := Scanner new typedScanTokens: self selection string. - ^tokens isEmpty ifFalse: [tokens first]!
Got it! :-o) I added tests for it (CollectionsTests-mt.328).
Best, Marcel Am 02.12.2019 09:31:32 schrieb Marcel Taeumel marcel.taeumel@hpi.de: Hi Eliot,
can you give an example string that would match #selectedLiteral but not #selectedSelector? Once I can understand this change, I can write some tests for it. :-)
Best, Marcel Am 01.12.2019 04:05:43 schrieb commits@source.squeak.org commits@source.squeak.org: Eliot Miranda uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-eem.1597.mcz
==================== Summary ====================
Name: Morphic-eem.1597 Author: eem Time: 30 November 2019, 7:05:24.872005 pm UUID: 068e0786-10ca-433e-9ec1-7c5cc2a15942 Ancestors: Morphic-eem.1596
Fix regression from hurried programming. Apologies!
=============== Diff against Morphic-eem.1596 ===============
Item was added: + ----- Method: TextEditor>>selectedLiteral (in category 'menu messages') ----- + selectedLiteral + "Try to make a literal out of the current text selection" + | tokens | + tokens := Scanner new typedScanTokens: self selection string. + ^tokens isEmpty ifFalse: [tokens first]!
Item was changed: ----- Method: TextEditor>>selectedSelector (in category 'menu messages') ----- selectedSelector "Try to make a selector out of the current text selection" + ^self selection string findSelector! - | tokens | - tokens := Scanner new typedScanTokens: self selection string. - ^tokens isEmpty ifFalse: [tokens first]!
squeak-dev@lists.squeakfoundation.org