David T. Lewis uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-tcj.827.mcz
==================== Summary ====================
Name: Tools-tcj.827 Author: tcj Time: 3 July 2018, 1:26:17.691671 pm UUID: 1faf6a9f-6246-4b95-a3aa-13b113afd08b Ancestors: Tools-cmm.826
Revert the change to File Contents Browser introduced in Tools-eem.660 which broke version browsing in the File Contents Browser. "Browse versions" now works again to browse versions of a given selector while browsing through a changeset.
=============== Diff against Tools-cmm.826 ===============
Item was changed: ----- Method: FileContentsBrowser>>browseVersions (in category 'other') ----- browseVersions + "Create and schedule a message set browser on all versions of the + currently selected message selector." + | class selector | + (selector := self selectedMessageName) ifNotNil: + [class := self selectedClassOrMetaClass. + (class exists and: [class realClass includesSelector: selector]) ifTrue: + [VersionsBrowser + browseVersionsOf: (class realClass compiledMethodAt: selector) + class: class realClass theNonMetaClass + meta: class realClass isMeta + category: self selectedMessageCategoryName + selector: selector]]! - "Create and schedule a message set browser on all versions of the currently selected message selector." - (ToolSet - browseVersionsOf: self selectedClassOrMetaClass - selector: self selectedMessageName) ifNil: [self changed: #flash]!
Moved from inbox to trunk to fill in the version history.
Dave
On Sun, Aug 19, 2018 at 01:45:46PM +0000, commits@source.squeak.org wrote:
David T. Lewis uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-tcj.827.mcz
==================== Summary ====================
Name: Tools-tcj.827 Author: tcj Time: 3 July 2018, 1:26:17.691671 pm UUID: 1faf6a9f-6246-4b95-a3aa-13b113afd08b Ancestors: Tools-cmm.826
Revert the change to File Contents Browser introduced in Tools-eem.660 which broke version browsing in the File Contents Browser. "Browse versions" now works again to browse versions of a given selector while browsing through a changeset.
=============== Diff against Tools-cmm.826 ===============
Item was changed: ----- Method: FileContentsBrowser>>browseVersions (in category 'other') ----- browseVersions
- "Create and schedule a message set browser on all versions of the
- currently selected message selector."
- | class selector |
- (selector := self selectedMessageName) ifNotNil:
[class := self selectedClassOrMetaClass.
(class exists and: [class realClass includesSelector: selector]) ifTrue:
[VersionsBrowser
browseVersionsOf: (class realClass compiledMethodAt: selector)
class: class realClass theNonMetaClass
meta: class realClass isMeta
category: self selectedMessageCategoryName
selector: selector]]!
- "Create and schedule a message set browser on all versions of the currently selected message selector."
- (ToolSet
browseVersionsOf: self selectedClassOrMetaClass
selector: self selectedMessageName) ifNil: [self changed: #flash]!
squeak-dev@lists.squeakfoundation.org