Vm-dev March 2018

vm-dev@lists.squeakfoundation.org

46 participants
218 discussions

[OpenSmalltalk/opensmalltalk-vm] libgit build fails because of libssl and libcrypto (#210)
by Javier Pimas 04 Dec '19

04 Dec '19

on /build.linux32x86/pharo.cog.spur/build I run ./mvm and get make[3]: *** No rule to make target '/usr/lib/i386-linux-gnu/libssl.so', needed by 'libgit2.so.0.25.1'. Stop. I worked around it by running sudo ln -s /lib/i386-linux-gnu/libssl.so.1.0.0 /usr/lib/i386-linux-gnu/libssl.so but shouldn't be necessary as libssl is downloaded and built by the script. The same happens with libcrypto -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/210

3 4

Image crashing on startup, apparently during GC
by Damien Pollet 03 Jun '19

03 Jun '19

Hi, I have a Pharo image that crashes the VM on startup. The crash report below seems to incriminate GC. Should I make it available somewhere online? What's most convenient? Process: Pharo [64892] Path: /Users/USER/*/Pharo.app/Contents/MacOS/Pharo Identifier: org.pharo.Pharo Version: 5.0.201708271955 (5.0.201708271955) Code Type: X86-64 (Native) Parent Process: ??? [64888] Responsible: Pharo [64892] User ID: 501 Date/Time: 2018-03-19 20:27:03.906 +0100 OS Version: Mac OS X 10.13.3 (17D102) Report Version: 12 Anonymous UUID: 6D022236-78DD-6676-117F-EADA56D5D1BE Sleep/Wake UUID: AC9E4E55-3CDB-4B4F-A6B4-51ACB1177154 Time Awake Since Boot: 28000 seconds Time Since Wake: 6500 seconds System Integrity Protection: enabled Crashed Thread: 0 Dispatch queue: com.apple.main-thread Exception Type: EXC_BAD_ACCESS (SIGABRT) Exception Codes: KERN_INVALID_ADDRESS at 0x000000012b67c0b0 Exception Note: EXC_CORPSE_NOTIFY VM Regions Near 0x12b67c0b0: VM_ALLOCATE 000000011adfc000-00000001259fc000 [172.0M] rw-/rwx SM=PRV --> STACK GUARD 0000700005613000-0000700005614000 [ 4K] ---/rwx SM=NUL stack guard for thread 1 Application Specific Information: abort() called Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 libsystem_kernel.dylib 0x00007fff53fbde3e __pthread_kill + 10 1 libsystem_pthread.dylib 0x00007fff540fc150 pthread_kill + 333 2 libsystem_c.dylib 0x00007fff53f1a312 abort + 127 3 org.pharo.Pharo 0x0000000104ed8997 sigsegv + 190 4 libsystem_platform.dylib 0x00007fff540eff5a _sigtramp + 26 5 ??? 000000000000000000 0 + 0 6 org.pharo.Pharo 0x0000000104e73558 markObjects + 464 7 org.pharo.Pharo 0x0000000104e72d40 fullGC + 72 8 org.pharo.Pharo 0x0000000104e92dea primitiveFullGC + 45 9 org.pharo.Pharo 0x0000000104e52425 interpret + 26715 10 org.pharo.Pharo 0x0000000104e5c7f6 enterSmalltalkExecutiveImplementation + 152 11 org.pharo.Pharo 0x0000000104e4be6c interpret + 674 12 org.pharo.Pharo 0x0000000104ed9cc1 -[sqSqueakMainApplication runSqueak] + 394 13 com.apple.Foundation 0x00007fff2e6d696c __NSFirePerformWithOrder + 360 14 com.apple.CoreFoundation 0x00007fff2c579127 __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__ + 23 15 com.apple.CoreFoundation 0x00007fff2c57904f __CFRunLoopDoObservers + 527 16 com.apple.CoreFoundation 0x00007fff2c55b6a8 __CFRunLoopRun + 1240 17 com.apple.CoreFoundation 0x00007fff2c55af43 CFRunLoopRunSpecific + 483 18 com.apple.HIToolbox 0x00007fff2b872e26 RunCurrentEventLoopInMode + 286 19 com.apple.HIToolbox 0x00007fff2b872a9f ReceiveNextEventCommon + 366 20 com.apple.HIToolbox 0x00007fff2b872914 _BlockUntilNextEventMatchingListInModeWithFilter + 64 21 com.apple.AppKit 0x00007fff29b3df5f _DPSNextEvent + 2085 22 com.apple.AppKit 0x00007fff2a2d3b4c -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 3044 23 com.apple.AppKit 0x00007fff29b32d6d -[NSApplication run] + 764 24 com.apple.AppKit 0x00007fff29b01f1a NSApplicationMain + 804 -- Damien Pollet type less, do more [ | ] http://people.untyped.org/damien.pollet

5 8

[OpenSmalltalk/opensmalltalk-vm] Second attempt to improve updateSCCSVersions (#227)
by Jakob Reschke 29 Dec '18

29 Dec '18

I finally got around to solve the "not a git repository" issue with my previous pull request. For the analysis see below. Please review and try it out before merging. When the script is run as a hook, the environment variable `GIT_DIR` is set to `.git` (path relative to the working tree) for regular repositories. This affects the behavior of `rev-parse`. When the script is run from the working tree and the checkout commands towards the bottom are executed, the script actually invokes itself as the post-checkout script. During that inner invocation, the script would `cd` to `.git/hooks`, and because of the GIT_DIR variable, `rev-parse` would then look for the git repository in `.git/hooks/.git`. This failed, of course. The second error message "unrecognized input" came from `git apply` when it was fed with empty input (because there were no uncommitted changes to either *Version.h file). Since GIT_DIR caused the trouble, why not use it to detect whether the script is run as a hook... You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/227 -- Commit Summary -- * Second attempt to improve updateSCCSVersions * Eschew --git-path because it was only added in Git 2.5 * Properly handle staged changes to the version headers * whitespace -- File Changes -- M scripts/updateSCCSVersions (40) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/227.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/227.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/227

5 9

[OpenSmalltalk/opensmalltalk-vm] Make updateSCCSVersions work in more situations (#213)
by Jakob Reschke 29 Dec '18

29 Dec '18

- allow spaces in paths (added quotes) - support cases where the repository is not in a .git directory at the top of the working tree - do not hardcode the directory level of this script - avoid stashing the whole working tree when only two well-known files need to be updated - touch should suffice to make a file different from its index version (i. e., eligible for checkout) Please review for compatibility and pick those parts of the changes that you like. You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/213 -- Commit Summary -- * make updateSCCSVersions work in more situations -- File Changes -- M scripts/updateSCCSVersions (26) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/213.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/213.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/213

5 9

[OpenSmalltalk/opensmalltalk-vm] HowToBuild doesn't have to mention missing libssl (#186)
by Nicolas Cellier 18 Oct '18

18 Oct '18

Because we don't need to link against libssl. Keep the hint from Eliot for an hypothetical libfoobar.dylib missing. You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/186 -- Commit Summary -- * HowToBuild doesn't have to mention missing libssl -- File Changes -- M build.macos32x86/HowToBuild (31) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/186.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/186.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/186

3 5

[OpenSmalltalk/opensmalltalk-vm] Boot images produced by 201801252341 VM don't bring up a window on launch (#196)
by Ryan Macnak 13 May '18

13 May '18

If I produce Newspeak [boot images](https://bitbucket.org/newspeaklanguage/nsboot) from the [201801252341 Mac VMs](https://github.com/OpenSmalltalk/opensmalltalk-vm/releases/tag/2018012…, these images do not bring up the UI when subsequently opened, either by the new VMs or old VMs. The new VMs are able to properly bring up images produced by old VMs. (Maybe there's some new headlessness property in the image header?) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/196

3 6

StackInterp/Cog>>transferTo: - assertValidExecutionPointe:r:s differences
by Ben Coman 06 May '18

06 May '18

Just curious about the difference in instructionPointer between these two... StackInterpreter>>transferTo: self assertValidExecutionPointe: instructionPointer + 1 r: framePointer s: stackPointer. CoIntepreter>>transferTo:from: self assertValidExecutionPointe: instructionPointer r: framePointer s: stackPointer. cheers -ben

3 8

[PATCH] added FilePlugin error code lookup function
by monty 25 Apr '18

25 Apr '18

--- platforms/Cross/plugins/FilePlugin/FilePlugin.h | 17 ++++++ .../plugins/FilePlugin/sqFilePluginBasicPrims.c | 56 ++++++++++++++++++ .../win32/plugins/FilePlugin/sqWin32FilePrims.c | 69 ++++++++++++++++++++++ 3 files changed, 142 insertions(+) diff --git a/platforms/Cross/plugins/FilePlugin/FilePlugin.h b/platforms/Cross/plugins/FilePlugin/FilePlugin.h index 13e7b7ce9..5d61733a0 100644 --- a/platforms/Cross/plugins/FilePlugin/FilePlugin.h +++ b/platforms/Cross/plugins/FilePlugin/FilePlugin.h @@ -44,6 +44,21 @@ typedef struct { #endif } SQFile; +enum { + SQ_FILE_ERROR, + SQ_FILE_PERMISSION_ERROR, + SQ_FILE_ALREADY_EXISTS_ERROR, + SQ_FILE_DOES_NOT_EXIST_ERROR, + SQ_FILE_RESOURCE_LIMIT_ERROR, + SQ_FILE_INVALID_OPERATION_ERROR, + SQ_FILE_IO_ERROR, + SQ_FILE_BAD_HANDLE_ERROR, + SQ_FILE_IS_DIRECTORY_ERROR, + SQ_FILE_IS_NOT_DIRECTORY_ERROR, + SQ_FILE_INVALID_NAME_ERROR, + SQ_FILE_IN_PROGRESS_ERROR +}; + /* file i/o */ sqInt sqFileAtEnd(SQFile *f); @@ -67,6 +82,8 @@ sqInt sqFileSync(SQFile *f); sqInt sqFileTruncate(SQFile *f,squeakFileOffsetType offset); sqInt sqFileThisSession(void); sqInt sqFileStdioHandlesInto(SQFile files[3]); +sqInt sqFileErrorCodeFromSystemErrorCode(sqInt errorCode); + /* directories */ diff --git a/platforms/Cross/plugins/FilePlugin/sqFilePluginBasicPrims.c b/platforms/Cross/plugins/FilePlugin/sqFilePluginBasicPrims.c index 48117181f..803ad5b8a 100755 --- a/platforms/Cross/plugins/FilePlugin/sqFilePluginBasicPrims.c +++ b/platforms/Cross/plugins/FilePlugin/sqFilePluginBasicPrims.c @@ -754,4 +754,60 @@ sqInt sqFileThisSession() { return thisSession; } + +sqInt +sqFileErrorCodeFromSystemErrorCode(sqInt errorCode) +{ + /* A switch statement is avoided, since some error codes, like EAGAIN/EWOULDBLOCK, can + overlap, and EINTR is not propagated as SQ_FILE_IN_PROGRESS_ERROR, since it should be + handled internally where possible and because only certain operations can be safely + reattempted after failing with EINTR + */ + if (errorCode == EACCES + || errorCode == EPERM + || errorCode == EROFS) + return SQ_FILE_PERMISSION_ERROR; + else if (errorCode == EEXIST) + return SQ_FILE_ALREADY_EXISTS_ERROR; + else if (errorCode == ENOENT + || errorCode == ENODEV + || errorCode == ENXIO) + return SQ_FILE_DOES_NOT_EXIST_ERROR; + else if (errorCode == EDQUOT + || errorCode == EFBIG + || errorCode == EMFILE + || errorCode == EMLINK + || errorCode == ENFILE + || errorCode == ENOLCK + || errorCode == ENOLINK + || errorCode == ENOMEM + || errorCode == ENOSPC) + return SQ_FILE_RESOURCE_LIMIT_ERROR; + else if (errorCode == EINVAL + || errorCode == ENOTTY + || errorCode == ENOSYS + || errorCode == ENOTEMPTY + || errorCode == EFAULT + || errorCode == ESPIPE + || errorCode == EXDEV) + return SQ_FILE_INVALID_OPERATION_ERROR; + else if (errorCode == EIO) + return SQ_FILE_IO_ERROR; + else if (errorCode == EBADF) + return SQ_FILE_BAD_HANDLE_ERROR; + else if (errorCode == EISDIR) + return SQ_FILE_IS_DIRECTORY_ERROR; + else if (errorCode == ENOTDIR) + return SQ_FILE_IS_NOT_DIRECTORY_ERROR; + else if (errorCode == ENAMETOOLONG + || errorCode == ELOOP) + return SQ_FILE_INVALID_NAME_ERROR; + else if (errorCode == EAGAIN + || errorCode == EWOULDBLOCK + || errorCode == EINPROGRESS) + return SQ_FILE_IN_PROGRESS_ERROR; + else + return SQ_FILE_ERROR; +} + #endif /* NO_STD_FILE_SUPPORT */ diff --git a/platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c b/platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c index 39ae4ec15..1e7d80782 100644 --- a/platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c +++ b/platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c @@ -528,4 +528,73 @@ squeakFileOffsetType sqImageFileSize(sqImageFile h) return ofs.offset; } +sqInt +sqFileErrorCodeFromSystemErrorCode(sqInt errorCode) +{ + /* Newer constants are avoided for backwards compatibility */ + if (errorCode == ERROR_ACCESS_DENIED + || errorCode == ERROR_FILE_READ_ONLY + || errorCode == ERROR_WRITE_PROTECT + || errorCode == 313) /* ERROR_NOT_ALLOWED_ON_SYSTEM_FILE */ + return SQ_FILE_PERMISSION_ERROR; + else if (errorCode == ERROR_FILE_EXISTS + || errorCode == ERROR_ALREADY_EXISTS) + return SQ_FILE_ALREADY_EXISTS_ERROR; + else if (errorCode == ERROR_FILE_NOT_FOUND + || errorCode == ERROR_PATH_NOT_FOUND + || errorCode == ERROR_DEV_NOT_EXIST) + return SQ_FILE_DOES_NOT_EXIST_ERROR; + else if (errorCode == ERROR_NO_MORE_FILES + || errorCode == ERROR_TOO_MANY_OPEN_FILES + || errorCode == ERROR_DISK_FULL + || errorCode == ERROR_HANDLE_DISK_FULL + || errorCode == ERROR_DISK_TOO_FRAGMENTED + || errorCode == ERROR_NO_MORE_SEARCH_HANDLES + || errorCode == ERROR_NOT_ENOUGH_QUOTA + || errorCode == 223 /* ERROR_FILE_TOO_LARGE */ + || errorCode == 314 /* ERROR_DISK_RESOURCES_EXHAUSTED */ + || errorCode == 322 /* ERROR_DEVICE_NO_RESOURCES */ + || errorCode == 331) /* ERROR_TOO_MANY_DESCRIPTORS */ + return SQ_FILE_RESOURCE_LIMIT_ERROR; + else if (errorCode == ERROR_WRITE_FAULT + || errorCode == ERROR_READ_FAULT + || errorCode == ERROR_OPERATION_ABORTED + || errorCode == ERROR_CANNOT_MAKE + || errorCode == ERROR_IO_DEVICE) + return SQ_FILE_IO_ERROR; + else if (errorCode == ERROR_INVALID_FUNCTION + || errorCode == ERROR_BAD_ARGUMENTS + || errorCode == ERROR_INVALID_PARAMETER + || errorCode == ERROR_NOT_SUPPORTED + || errorCode == ERROR_NEGATIVE_SEEK + || errorCode == ERROR_SEEK_ON_DEVICE + || errorCode == ERROR_CURRENT_DIRECTORY + || errorCode == ERROR_DIR_NOT_EMPTY) + return SQ_FILE_INVALID_OPERATION_ERROR; + else if (errorCode == ERROR_INVALID_HANDLE + || errorCode == ERROR_INVALID_TARGET_HANDLE + || errorCode == ERROR_DIRECT_ACCESS_HANDLE + || errorCode == ERROR_OPEN_FAILED + || errorCode == ERROR_DELETE_PENDING + || errorCode == 321) /* ERROR_DEVICE_UNREACHABLE */ + return SQ_FILE_BAD_HANDLE_ERROR; + else if (errorCode == 336) /* ERROR_DIRECTORY_NOT_SUPPORTED */ + return SQ_FILE_IS_DIRECTORY_ERROR; + else if (errorCode == 334 /* ERROR_RESIDENT_FILE_NOT_SUPPORTED */ + || errorCode == 335) /* ERROR_COMPRESSED_FILE_NOT_SUPPORTED */ + return SQ_FILE_IS_NOT_DIRECTORY_ERROR; + else if (errorCode == ERROR_INVALID_NAME + || errorCode == ERROR_DIRECTORY + || errorCode == ERROR_BAD_PATHNAME + || errorCode == ERROR_FILENAME_EXCED_RANGE + || errorCode == 305 /* ERROR_SHORT_NAMES_NOT_ENABLED_ON_VOLUME */ + || errorCode == 330) /* ERROR_BAD_DEVICE_PATH */ + return SQ_FILE_INVALID_NAME_ERROR; + else if (errorCode == ERROR_IO_PENDING + || errorCode == ERROR_IO_INCOMPLETE) + return SQ_FILE_IN_PROGRESS_ERROR; + else + return SQ_FILE_ERROR; +} + #endif /* WIN32_FILE_SUPPORT */ -- 2.11.0

4 10

VM Maker: VMMaker.oscog-eem.2338.mcz
by commits＠source.squeak.org 15 Apr '18

15 Apr '18

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2338.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2338 Author: eem Time: 22 February 2018, 10:25:17.794166 am UUID: 1672c678-41b4-41f2-a061-e201562fc75c Ancestors: VMMaker.oscog-eem.2337 Fix a slip in primitiveDecompressFromByteArray caught by IncludedMethodsTests. Thank you David! =============== Diff against VMMaker.oscog-eem.2337 =============== Item was changed: ----- Method: MiscPrimitivePlugin>>primitiveDecompressFromByteArray (in category 'primitives') ----- primitiveDecompressFromByteArray "Bitmap decompress: bm fromByteArray: ba at: index" <export: true> | bm ba index i anInt code data end k n pastEnd | <var: 'ba' type: #'unsigned char *'> <var: 'bm' type: #'int *'> <var: 'anInt' type: #'unsigned int'> <var: 'code' type: #'unsigned int'> <var: 'data' type: #'unsigned int'> <var: 'n' type: #'unsigned int'> bm := self cCode: [interpreterProxy arrayValueOf: (interpreterProxy stackValue: 2)] inSmalltalk: [interpreterProxy cCoerce: (interpreterProxy arrayValueOf: (interpreterProxy stackValue: 2)) to: #'int *']. (interpreterProxy isOopImmutable: (interpreterProxy stackValue: 2)) ifTrue: [^interpreterProxy primitiveFailFor: PrimErrNoModification]. (interpreterProxy isBytes: (interpreterProxy stackValue: 1)) ifFalse: [^interpreterProxy primitiveFail]. ba := interpreterProxy firstIndexableField: (interpreterProxy stackValue: 1). index := interpreterProxy stackIntegerValue: 0. interpreterProxy failed ifTrue: [^nil]. i := index - 1. k := 0. end := interpreterProxy sizeOfSTArrayFromCPrimitive: ba. pastEnd := interpreterProxy sizeOfSTArrayFromCPrimitive: bm. [i < end] whileTrue: [anInt := ba at: i. i := i + 1. anInt <= 223 ifFalse: [anInt <= 254 ifTrue: [anInt := anInt - 224 * 256 + (ba at: i). i := i + 1] ifFalse: [anInt := 0. 1 to: 4 by: 1 do: [ :j | anInt := (anInt bitShift: 8) + (ba at: i). i := i + 1]]]. n := anInt >> 2. + k + n > pastEnd ifTrue: [^interpreterProxy primitiveFail]. - k + n >= pastEnd ifTrue: [^interpreterProxy primitiveFail]. code := anInt bitAnd: 3. "code = 0 ifTrue: [nil]." code = 1 ifTrue: [data := ba at: i. i := i + 1. data := data bitOr: (data bitShift: 8). data := data bitOr: (data bitShift: 16). 1 to: n do: [ :j | bm at: k put: data. k := k + 1]]. code = 2 ifTrue: [data := 0. 1 to: 4 do: [ :j | data := (data bitShift: 8) bitOr: (ba at: i). i := i + 1]. 1 to: n do: [ :j | bm at: k put: data. k := k + 1]]. code = 3 ifTrue: [1 to: n do: [ :m | data := 0. 1 to: 4 do: [ :j | data := (data bitShift: 8) bitOr: (ba at: i). i := i + 1]. bm at: k put: data. k := k + 1]]]. interpreterProxy pop: interpreterProxy methodArgumentCount!

3 6

[OpenSmalltalk/opensmalltalk-vm] Readonly primitives are missing in ARM VM (#216)
by Denis Kudriashov 06 Apr '18

06 Apr '18

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/216

5 13

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev March 2018