Current VM build problems. (was: Fwd: Errored: OpenSmalltalk/opensmalltalk-vm#835 (Cog - 7dff211))
Hi all,
currently the vm fails to build properly due to two main problems:
a) #testBecomeIdentityHash fails on Squeak5.1 for linux32x86 squeak.cog.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505448#L3172 linux32x86 squeak.sista.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505458#L3208 linux32x86 squeak.stack.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505461#L1842 macos32x86 squeak.cog.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505499#L8455 macos32x86 squeak.sista.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505503#L8517 macos32x86 squeak.stack.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505505#L7383 (Or said differently: on 32x86 for squeak.*.spur)
I recall we had problems there but I thought those were fixed 2..3 years ago? Someone can comment?
b) the pharo deployment seems to not work correctly:
https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505445#L1900 https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505471#L8223 https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505444#L1900
for 64x64 pharo.cog.spur. If it is correct that those 3 vms cannot be deployed, please fix the deploy script to not try to. IF incorrect, pleas fix on your side/site.
Best regards -Tobias
Begin forwarded message:
From: Travis CI builds@travis-ci.org Subject: Errored: OpenSmalltalk/opensmalltalk-vm#835 (Cog - 7dff211) Date: 29. August 2017 um 13:02:09 MESZ
OpenSmalltalk / opensmalltalk-vm (Cog)
Build #835 has errored. 48 minutes and 25 seconds Tobias Pape 7dff211 Changeset → [squeakssl] follow suit with the unix hostname validation things Want to know about upcoming build environment updates? Would you like to stay up-to-date with the upcoming Travis CI build environment updates? We set up a mailing list for you! Sign up here. Documentation about Travis CI Need help? Mail support! Choose who receives these build notification emails in your configuration file.
Would you like to test your private code? Travis CI for Private Projects could be your new best friend!
2017-08-29 13:39 GMT+02:00 Tobias Pape Das.Linux@gmx.de:
Hi all,
currently the vm fails to build properly due to two main problems:
a) #testBecomeIdentityHash fails on Squeak5.1 for linux32x86 squeak.cog.spur https://travis-ci.org/OpenSmal ltalk/opensmalltalk-vm/jobs/269505448#L3172 linux32x86 squeak.sista.spur https://travis-ci.org/OpenSmal ltalk/opensmalltalk-vm/jobs/269505458#L3208 linux32x86 squeak.stack.spur https://travis-ci.org/OpenSmal ltalk/opensmalltalk-vm/jobs/269505461#L1842 macos32x86 squeak.cog.spur https://travis-ci.org/OpenSmal ltalk/opensmalltalk-vm/jobs/269505499#L8455 macos32x86 squeak.sista.spur https://travis-ci.org/OpenSmal ltalk/opensmalltalk-vm/jobs/269505503#L8517 macos32x86 squeak.stack.spur https://travis-ci.org/OpenSmal ltalk/opensmalltalk-vm/jobs/269505505#L7383 (Or said differently: on 32x86 for squeak.*.spur)
I recall we had problems there but I thought those were fixed 2..3 years ago? Someone can comment?
It fails for more than 2 months (build #808) in any case in we look at Travis history (i can't backtrack more than that)... Did it ever work in spur? If I take VM from https://bintray.com/opensmalltalk/vm/cog, it worked until 201705281305 https://bintray.com/opensmalltalk/vm/cog/201705281305but 201706280928 https://bintray.com/opensmalltalk/vm/cog/201706280928fails.
The testBecomeIdentityHash did not change recently (it's from 2012)
Become had minor changes in July, so it's something before that... (only a new primitive for 1-way without copyHash has been added recently... and a primitive failure in case of immutability )
The problem must be somewhere between VMMaker.oscog-nice.2224 and VMMaker.oscog-eem.2245
Nicolas
b) the pharo deployment seems to not work correctly:
https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505445#L1900 https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/26 9505471#L8223 https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/26 9505444#L1900
for 64x64 pharo.cog.spur. If it is correct that those 3 vms cannot be deployed, please fix the deploy script to not try to. IF incorrect, pleas fix on your side/site.
Best regards -Tobias
Begin forwarded message:
From: Travis CI builds@travis-ci.org Subject: Errored: OpenSmalltalk/opensmalltalk-vm#835 (Cog - 7dff211) Date: 29. August 2017 um 13:02:09 MESZ
OpenSmalltalk / opensmalltalk-vm (Cog)
Build #835 has errored. 48 minutes and 25 seconds Tobias Pape 7dff211 Changeset → [squeakssl] follow suit with the unix hostname validation things Want to know about upcoming build environment updates? Would you like to stay up-to-date with the upcoming Travis CI build
environment updates? We set up a mailing list for you! Sign up here.
Documentation about Travis CINeed help? Mail support! Choose who receives these build notification emails in your
configuration file.
Would you like to test your private code? Travis CI for Private Projects could be your new best friend!
Hi Nicolas
On 31.08.2017, at 04:42, Nicolas Cellier nicolas.cellier.aka.nice@gmail.com wrote:
2017-08-29 13:39 GMT+02:00 Tobias Pape Das.Linux@gmx.de:
Hi all,
currently the vm fails to build properly due to two main problems:
a) #testBecomeIdentityHash fails on Squeak5.1 for linux32x86 squeak.cog.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505448#L3172 linux32x86 squeak.sista.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505458#L3208 linux32x86 squeak.stack.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505461#L1842 macos32x86 squeak.cog.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505499#L8455 macos32x86 squeak.sista.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505503#L8517 macos32x86 squeak.stack.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505505#L7383 (Or said differently: on 32x86 for squeak.*.spur)
I recall we had problems there but I thought those were fixed 2..3 years ago? Someone can comment?
It fails for more than 2 months (build #808) in any case in we look at Travis history (i can't backtrack more than that)... Did it ever work in spur? If I take VM from https://bintray.com/opensmalltalk/vm/cog, it worked until 201705281305 but 201706280928 fails.
The testBecomeIdentityHash did not change recently (it's from 2012)
Become had minor changes in July, so it's something before that... (only a new primitive for 1-way without copyHash has been added recently... and a primitive failure in case of immutability )
The problem must be somewhere between VMMaker.oscog-nice.2224 and VMMaker.oscog-eem.2245
Thanks for bisecting that. I don't know hot to go on here, tho… Eliot, can you give me a pointer?
Best regards -tobias
Nicolas
b) the pharo deployment seems to not work correctly:
https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505445#L1900 https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505471#L8223 https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505444#L1900for 64x64 pharo.cog.spur. If it is correct that those 3 vms cannot be deployed, please fix the deploy script to not try to. IF incorrect, pleas fix on your side/site.
Best regards -Tobias
Begin forwarded message:
From: Travis CI builds@travis-ci.org Subject: Errored: OpenSmalltalk/opensmalltalk-vm#835 (Cog - 7dff211) Date: 29. August 2017 um 13:02:09 MESZ
OpenSmalltalk / opensmalltalk-vm (Cog)
Build #835 has errored. 48 minutes and 25 seconds Tobias Pape 7dff211 Changeset → [squeakssl] follow suit with the unix hostname validation things Want to know about upcoming build environment updates? Would you like to stay up-to-date with the upcoming Travis CI build environment updates? We set up a mailing list for you! Sign up here. Documentation about Travis CI Need help? Mail support! Choose who receives these build notification emails in your configuration file.
Would you like to test your private code? Travis CI for Private Projects could be your new best friend!
2017-08-31 10:59 GMT+02:00 Tobias Pape Das.Linux@gmx.de:
Hi Nicolas
On 31.08.2017, at 04:42, Nicolas Cellier <nicolas.cellier.aka.nice@
gmail.com> wrote:
2017-08-29 13:39 GMT+02:00 Tobias Pape Das.Linux@gmx.de:
Hi all,
currently the vm fails to build properly due to two main problems:
a) #testBecomeIdentityHash fails on Squeak5.1 for linux32x86 squeak.cog.spur https://travis-ci.org/
OpenSmalltalk/opensmalltalk-vm/jobs/269505448#L3172
linux32x86 squeak.sista.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505458#L3208
linux32x86 squeak.stack.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505461#L1842
macos32x86 squeak.cog.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505499#L8455
macos32x86 squeak.sista.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505503#L8517
macos32x86 squeak.stack.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505505#L7383
(Or said differently: on 32x86 for squeak.*.spur)
I recall we had problems there but I thought those were fixed 2..3 years
ago?
Someone can comment?
It fails for more than 2 months (build #808) in any case in we look at
Travis history (i can't backtrack more than that)...
Did it ever work in spur? If I take VM from https://bintray.com/opensmalltalk/vm/cog, it worked until 201705281305 but 201706280928 fails.
The testBecomeIdentityHash did not change recently (it's from 2012)
Become had minor changes in July, so it's something before that... (only a new primitive for 1-way without copyHash has been added
recently...
and a primitive failure in case of immutability )
The problem must be somewhere between VMMaker.oscog-nice.2224 and
VMMaker.oscog-eem.2245
Thanks for bisecting that. I don't know hot to go on here, tho… Eliot, can you give me a pointer?
Best regards -tobias
Seeking for a narrower interval:
thess commit pass green: 6a63f68a3dd4deb7c17dd2c7ac6e4dd4b0b6d937 (comment: CogVM source as per VMMaker.oscog-eem.2232, May 31) 5ec678cdc4c1c2a66ef81b47762b7338d8ee81d1 (comment: CogVM source as per VMMaker.oscog-eem.2240, Jun 10) 9a98be0c6d5968627db24a3e4d97d0be28fba27c (comment: CogVm source as per VMMaker.oscog-eem.2241, Jun 10) b1bb2e26d0efe204b742681ba5674d9af57a4304 (comment: CogVM source as per VMMaker.oscog-eem.2242, Jun 13) db29f6214e325d97a245748aad27ff90b17e0e5c (comment: [osx] fix guard, again, Jun 15)
this commit fails red: 3010e4465405f6ec7a289fc3a3d21eb324816a8f (comment: CogVM source as per VMMaker.oscog-eem.2243, Jun 16)
VMMaker 2243 introduces a CodeGeneration change, so it's probably the cause and we'll have to analyze the diff of generated code...
Nicolas
b) the pharo deployment seems to not work correctly:
https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505445#L1900
https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505471#L8223
https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505444#L1900
for 64x64 pharo.cog.spur. If it is correct that those 3 vms cannot be deployed, please fix the
deploy script to not try to.
IF incorrect, pleas fix on your side/site.
Best regards -Tobias
Begin forwarded message:
From: Travis CI builds@travis-ci.org Subject: Errored: OpenSmalltalk/opensmalltalk-vm#835 (Cog - 7dff211) Date: 29. August 2017 um 13:02:09 MESZ
OpenSmalltalk / opensmalltalk-vm (Cog)
Build #835 has errored. 48 minutes and 25 seconds Tobias Pape 7dff211 Changeset → [squeakssl] follow suit with the unix hostname validation things Want to know about upcoming build environment updates? Would you like to stay up-to-date with the upcoming Travis CI build
environment updates? We set up a mailing list for you! Sign up here.
Documentation about Travis CINeed help? Mail support! Choose who receives these build notification emails in your
configuration file.
Would you like to test your private code? Travis CI for Private Projects could be your new best friend!
2017-08-31 14:11 GMT+02:00 Nicolas Cellier < nicolas.cellier.aka.nice@gmail.com>:
2017-08-31 10:59 GMT+02:00 Tobias Pape Das.Linux@gmx.de:
Hi Nicolas
On 31.08.2017, at 04:42, Nicolas Cellier <nicolas.cellier.aka.nice@gmai
l.com> wrote:
2017-08-29 13:39 GMT+02:00 Tobias Pape Das.Linux@gmx.de:
Hi all,
currently the vm fails to build properly due to two main problems:
a) #testBecomeIdentityHash fails on Squeak5.1 for linux32x86 squeak.cog.spur https://travis-ci.org/OpenSmal
ltalk/opensmalltalk-vm/jobs/269505448#L3172
linux32x86 squeak.sista.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505458#L3208
linux32x86 squeak.stack.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505461#L1842
macos32x86 squeak.cog.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505499#L8455
macos32x86 squeak.sista.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505503#L8517
macos32x86 squeak.stack.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505505#L7383
(Or said differently: on 32x86 for squeak.*.spur)
I recall we had problems there but I thought those were fixed 2..3
years ago?
Someone can comment?
It fails for more than 2 months (build #808) in any case in we look at
Travis history (i can't backtrack more than that)...
Did it ever work in spur? If I take VM from https://bintray.com/opensmalltalk/vm/cog, it worked until 201705281305 but 201706280928 fails.
The testBecomeIdentityHash did not change recently (it's from 2012)
Become had minor changes in July, so it's something before that... (only a new primitive for 1-way without copyHash has been added
recently...
and a primitive failure in case of immutability )
The problem must be somewhere between VMMaker.oscog-nice.2224 and
VMMaker.oscog-eem.2245
Thanks for bisecting that. I don't know hot to go on here, tho… Eliot, can you give me a pointer?
Best regards -tobias
Seeking for a narrower interval:
thess commit pass green: 6a63f68a3dd4deb7c17dd2c7ac6e4dd4b0b6d937 (comment: CogVM source as per VMMaker.oscog-eem.2232, May 31) 5ec678cdc4c1c2a66ef81b47762b7338d8ee81d1 (comment: CogVM source as per VMMaker.oscog-eem.2240, Jun 10) 9a98be0c6d5968627db24a3e4d97d0be28fba27c (comment: CogVm source as per VMMaker.oscog-eem.2241, Jun 10) b1bb2e26d0efe204b742681ba5674d9af57a4304 (comment: CogVM source as per VMMaker.oscog-eem.2242, Jun 13) db29f6214e325d97a245748aad27ff90b17e0e5c (comment: [osx] fix guard, again, Jun 15)
this commit fails red: 3010e4465405f6ec7a289fc3a3d21eb324816a8f (comment: CogVM source as per VMMaker.oscog-eem.2243, Jun 16)
VMMaker 2243 introduces a CodeGeneration change, so it's probably the cause and we'll have to analyze the diff of generated code...
Ah, ah, if I checkout 3010e4465405f6ec7a289fc3a3d21eb324816a8f and diff against parent git difftool --tool=sourcetree db29f6214e325d97a245748aad27ff90b17e0e5c spursrc/vm/cointerp.c (sourcedtree configured with winmerge) i get the interesting diff attached...
hash1 and hash2 are now typed sqInt (32 bits on 32 bits VM) instead of sqLong (64 bits). since we do: hash1 = header1 & 0x3FFFFF00000000LL; that ain't going to work well with 32 bits long hash1... That also can explain that spur64 still works OK.
So a type inference that did previously work no more does...
Nicolas
Nicolas
b) the pharo deployment seems to not work correctly:
https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505445#L1900
https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505471#L8223
https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505444#L1900
for 64x64 pharo.cog.spur. If it is correct that those 3 vms cannot be deployed, please fix the
deploy script to not try to.
IF incorrect, pleas fix on your side/site.
Best regards -Tobias
Begin forwarded message:
From: Travis CI builds@travis-ci.org Subject: Errored: OpenSmalltalk/opensmalltalk-vm#835 (Cog - 7dff211) Date: 29. August 2017 um 13:02:09 MESZ
OpenSmalltalk / opensmalltalk-vm (Cog)
Build #835 has errored. 48 minutes and 25 seconds Tobias Pape 7dff211 Changeset → [squeakssl] follow suit with the unix hostname validation things Want to know about upcoming build environment updates? Would you like to stay up-to-date with the upcoming Travis CI build
environment updates? We set up a mailing list for you! Sign up here.
Documentation about Travis CINeed help? Mail support! Choose who receives these build notification emails in your
configuration file.
Would you like to test your private code? Travis CI for Private Projects could be your new best friend!
2017-08-31 14:11 GMT+02:00 Nicolas Cellier <nicolas.cellier.aka.nice@ gmail.com>:
2017-08-31 10:59 GMT+02:00 Tobias Pape Das.Linux@gmx.de:
Hi Nicolas
On 31.08.2017, at 04:42, Nicolas Cellier <nicolas.cellier.aka.nice@gmai
l.com> wrote:
2017-08-29 13:39 GMT+02:00 Tobias Pape Das.Linux@gmx.de:
Hi all,
currently the vm fails to build properly due to two main problems:
a) #testBecomeIdentityHash fails on Squeak5.1 for linux32x86 squeak.cog.spur https://travis-ci.org/OpenSmal
ltalk/opensmalltalk-vm/jobs/269505448#L3172
linux32x86 squeak.sista.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505458#L3208
linux32x86 squeak.stack.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505461#L1842
macos32x86 squeak.cog.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505499#L8455
macos32x86 squeak.sista.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505503#L8517
macos32x86 squeak.stack.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505505#L7383
(Or said differently: on 32x86 for squeak.*.spur)
I recall we had problems there but I thought those were fixed 2..3
years ago?
Someone can comment?
It fails for more than 2 months (build #808) in any case in we look at
Travis history (i can't backtrack more than that)...
Did it ever work in spur? If I take VM from https://bintray.com/opensmalltalk/vm/cog, it worked until 201705281305 but 201706280928 fails.
The testBecomeIdentityHash did not change recently (it's from 2012)
Become had minor changes in July, so it's something before that... (only a new primitive for 1-way without copyHash has been added
recently...
and a primitive failure in case of immutability )
The problem must be somewhere between VMMaker.oscog-nice.2224 and
VMMaker.oscog-eem.2245
Thanks for bisecting that. I don't know hot to go on here, tho… Eliot, can you give me a pointer?
Best regards -tobias
Seeking for a narrower interval:
thess commit pass green: 6a63f68a3dd4deb7c17dd2c7ac6e4dd4b0b6d937 (comment: CogVM source as per VMMaker.oscog-eem.2232, May 31) 5ec678cdc4c1c2a66ef81b47762b7338d8ee81d1 (comment: CogVM source as per VMMaker.oscog-eem.2240, Jun 10) 9a98be0c6d5968627db24a3e4d97d0be28fba27c (comment: CogVm source as per VMMaker.oscog-eem.2241, Jun 10) b1bb2e26d0efe204b742681ba5674d9af57a4304 (comment: CogVM source as per VMMaker.oscog-eem.2242, Jun 13) db29f6214e325d97a245748aad27ff90b17e0e5c (comment: [osx] fix guard, again, Jun 15)
this commit fails red: 3010e4465405f6ec7a289fc3a3d21eb324816a8f (comment: CogVM source as per VMMaker.oscog-eem.2243, Jun 16)
VMMaker 2243 introduces a CodeGeneration change, so it's probably the cause and we'll have to analyze the diff of generated code...
Ah, ah, if I checkout 3010e4465405f6ec7a289fc3a3d21eb324816a8f and diff against parent git difftool --tool=sourcetree db29f6214e325d97a245748aad27ff90b17e0e5c spursrc/vm/cointerp.c (sourcedtree configured with winmerge) i get the interesting diff attached...
hash1 and hash2 are now type sqInt (32 bits on 32 bits VM) instead of sqLong (64 bits). So a type inference that did previously work no more does...
-- retry with attachment --
Nicolas
b) the pharo deployment seems to not work correctly:
https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505445#L1900
https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505471#L8223
https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505444#L1900
for 64x64 pharo.cog.spur. If it is correct that those 3 vms cannot be deployed, please fix the
deploy script to not try to.
IF incorrect, pleas fix on your side/site.
Best regards -Tobias
Begin forwarded message:
From: Travis CI builds@travis-ci.org Subject: Errored: OpenSmalltalk/opensmalltalk-vm#835 (Cog - 7dff211) Date: 29. August 2017 um 13:02:09 MESZ
OpenSmalltalk / opensmalltalk-vm (Cog)
Build #835 has errored. 48 minutes and 25 seconds Tobias Pape 7dff211 Changeset → [squeakssl] follow suit with the unix hostname validation things Want to know about upcoming build environment updates? Would you like to stay up-to-date with the upcoming Travis CI build
environment updates? We set up a mailing list for you! Sign up here.
Documentation about Travis CINeed help? Mail support! Choose who receives these build notification emails in your
configuration file.
Would you like to test your private code? Travis CI for Private Projects could be your new best friend!
Hi Nicolas,
thanks for narrowing this down! I'm trying to fix this now. Tobias, thanks for the heads up. Is it possible to get email notifications when builds start to fail, not on every failing build?
On Thu, Aug 31, 2017 at 7:59 AM, Nicolas Cellier < nicolas.cellier.aka.nice@gmail.com> wrote:
2017-08-31 14:11 GMT+02:00 Nicolas Cellier <nicolas.cellier.aka.nice@gmai l.com>:
2017-08-31 10:59 GMT+02:00 Tobias Pape Das.Linux@gmx.de:
Hi Nicolas
On 31.08.2017, at 04:42, Nicolas Cellier <
nicolas.cellier.aka.nice@gmail.com> wrote:
2017-08-29 13:39 GMT+02:00 Tobias Pape Das.Linux@gmx.de:
Hi all,
currently the vm fails to build properly due to two main problems:
a) #testBecomeIdentityHash fails on Squeak5.1 for linux32x86 squeak.cog.spur https://travis-ci.org/OpenSmal
ltalk/opensmalltalk-vm/jobs/269505448#L3172
linux32x86 squeak.sista.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505458#L3208
linux32x86 squeak.stack.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505461#L1842
macos32x86 squeak.cog.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505499#L8455
macos32x86 squeak.sista.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505503#L8517
macos32x86 squeak.stack.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505505#L7383
(Or said differently: on 32x86 for squeak.*.spur)
I recall we had problems there but I thought those were fixed 2..3
years ago?
Someone can comment?
It fails for more than 2 months (build #808) in any case in we look at
Travis history (i can't backtrack more than that)...
Did it ever work in spur? If I take VM from https://bintray.com/opensmalltalk/vm/cog, it worked until 201705281305 but 201706280928 fails.
The testBecomeIdentityHash did not change recently (it's from 2012)
Become had minor changes in July, so it's something before that... (only a new primitive for 1-way without copyHash has been added
recently...
and a primitive failure in case of immutability )
The problem must be somewhere between VMMaker.oscog-nice.2224 and
VMMaker.oscog-eem.2245
Thanks for bisecting that. I don't know hot to go on here, tho… Eliot, can you give me a pointer?
Best regards -tobias
Seeking for a narrower interval:
thess commit pass green: 6a63f68a3dd4deb7c17dd2c7ac6e4dd4b0b6d937 (comment: CogVM source as per VMMaker.oscog-eem.2232, May 31) 5ec678cdc4c1c2a66ef81b47762b7338d8ee81d1 (comment: CogVM source as per VMMaker.oscog-eem.2240, Jun 10) 9a98be0c6d5968627db24a3e4d97d0be28fba27c (comment: CogVm source as per VMMaker.oscog-eem.2241, Jun 10) b1bb2e26d0efe204b742681ba5674d9af57a4304 (comment: CogVM source as per VMMaker.oscog-eem.2242, Jun 13) db29f6214e325d97a245748aad27ff90b17e0e5c (comment: [osx] fix guard, again, Jun 15)
this commit fails red: 3010e4465405f6ec7a289fc3a3d21eb324816a8f (comment: CogVM source as per VMMaker.oscog-eem.2243, Jun 16)
VMMaker 2243 introduces a CodeGeneration change, so it's probably the cause and we'll have to analyze the diff of generated code...
Ah, ah, if I checkout 3010e4465405f6ec7a289fc3a3d21eb324816a8f and diff against parent git difftool --tool=sourcetree db29f6214e325d97a245748aad27ff90b17e0e5c spursrc/vm/cointerp.c (sourcedtree configured with winmerge) i get the interesting diff attached...
hash1 and hash2 are now type sqInt (32 bits on 32 bits VM) instead of sqLong (64 bits). So a type inference that did previously work no more does...
-- retry with attachment --
Nicolas
b) the pharo deployment seems to not work correctly:
https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505445#L1900
https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505471#L8223
https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505444#L1900
for 64x64 pharo.cog.spur. If it is correct that those 3 vms cannot be deployed, please fix the
deploy script to not try to.
IF incorrect, pleas fix on your side/site.
Best regards -Tobias
Begin forwarded message:
From: Travis CI builds@travis-ci.org Subject: Errored: OpenSmalltalk/opensmalltalk-vm#835 (Cog - 7dff211) Date: 29. August 2017 um 13:02:09 MESZ
OpenSmalltalk / opensmalltalk-vm (Cog)
Build #835 has errored. 48 minutes and 25 seconds Tobias Pape 7dff211 Changeset → [squeakssl] follow suit with the unix hostname validation
things
Want to know about upcoming build environment updates? Would you like to stay up-to-date with the upcoming Travis CI build
environment updates? We set up a mailing list for you! Sign up here.
Documentation about Travis CINeed help? Mail support! Choose who receives these build notification emails in your
configuration file.
Would you like to test your private code? Travis CI for Private Projects could be your new best friend!
Hi eliot,
On 31.08.2017, at 19:14, Eliot Miranda eliot.miranda@gmail.com wrote:
Hi Nicolas,
thanks for narrowing this down! I'm trying to fix this now. Tobias, thanks for the heads up. Is it possible to get email notifications when builds start to fail, not on every failing build?
No. Sadly we have to detect the falling edge ourselves.
Best regards -Tobias
On Thu, Aug 31, 2017 at 7:59 AM, Nicolas Cellier nicolas.cellier.aka.nice@gmail.com wrote:
2017-08-31 14:11 GMT+02:00 Nicolas Cellier nicolas.cellier.aka.nice@gmail.com:
2017-08-31 10:59 GMT+02:00 Tobias Pape Das.Linux@gmx.de:
Hi Nicolas
On 31.08.2017, at 04:42, Nicolas Cellier nicolas.cellier.aka.nice@gmail.com wrote:
2017-08-29 13:39 GMT+02:00 Tobias Pape Das.Linux@gmx.de:
Hi all,
currently the vm fails to build properly due to two main problems:
a) #testBecomeIdentityHash fails on Squeak5.1 for linux32x86 squeak.cog.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505448#L3172 linux32x86 squeak.sista.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505458#L3208 linux32x86 squeak.stack.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505461#L1842 macos32x86 squeak.cog.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505499#L8455 macos32x86 squeak.sista.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505503#L8517 macos32x86 squeak.stack.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505505#L7383 (Or said differently: on 32x86 for squeak.*.spur)
I recall we had problems there but I thought those were fixed 2..3 years ago? Someone can comment?
It fails for more than 2 months (build #808) in any case in we look at Travis history (i can't backtrack more than that)... Did it ever work in spur? If I take VM from https://bintray.com/opensmalltalk/vm/cog, it worked until 201705281305 but 201706280928 fails.
The testBecomeIdentityHash did not change recently (it's from 2012)
Become had minor changes in July, so it's something before that... (only a new primitive for 1-way without copyHash has been added recently... and a primitive failure in case of immutability )
The problem must be somewhere between VMMaker.oscog-nice.2224 and VMMaker.oscog-eem.2245
Thanks for bisecting that. I don't know hot to go on here, tho… Eliot, can you give me a pointer?
Best regards -tobias
Seeking for a narrower interval:
thess commit pass green: 6a63f68a3dd4deb7c17dd2c7ac6e4dd4b0b6d937 (comment: CogVM source as per VMMaker.oscog-eem.2232, May 31) 5ec678cdc4c1c2a66ef81b47762b7338d8ee81d1 (comment: CogVM source as per VMMaker.oscog-eem.2240, Jun 10) 9a98be0c6d5968627db24a3e4d97d0be28fba27c (comment: CogVm source as per VMMaker.oscog-eem.2241, Jun 10) b1bb2e26d0efe204b742681ba5674d9af57a4304 (comment: CogVM source as per VMMaker.oscog-eem.2242, Jun 13) db29f6214e325d97a245748aad27ff90b17e0e5c (comment: [osx] fix guard, again, Jun 15)
this commit fails red: 3010e4465405f6ec7a289fc3a3d21eb324816a8f (comment: CogVM source as per VMMaker.oscog-eem.2243, Jun 16)
VMMaker 2243 introduces a CodeGeneration change, so it's probably the cause and we'll have to analyze the diff of generated code...
Ah, ah, if I checkout 3010e4465405f6ec7a289fc3a3d21eb324816a8f and diff against parent git difftool --tool=sourcetree db29f6214e325d97a245748aad27ff90b17e0e5c spursrc/vm/cointerp.c (sourcedtree configured with winmerge) i get the interesting diff attached...
hash1 and hash2 are now type sqInt (32 bits on 32 bits VM) instead of sqLong (64 bits). So a type inference that did previously work no more does...
-- retry with attachment --
Nicolas
b) the pharo deployment seems to not work correctly:
https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505445#L1900 https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505471#L8223 https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505444#L1900for 64x64 pharo.cog.spur. If it is correct that those 3 vms cannot be deployed, please fix the deploy script to not try to. IF incorrect, pleas fix on your side/site.
Best regards -Tobias
Begin forwarded message:
From: Travis CI builds@travis-ci.org Subject: Errored: OpenSmalltalk/opensmalltalk-vm#835 (Cog - 7dff211) Date: 29. August 2017 um 13:02:09 MESZ
OpenSmalltalk / opensmalltalk-vm (Cog)
Build #835 has errored. 48 minutes and 25 seconds Tobias Pape 7dff211 Changeset → [squeakssl] follow suit with the unix hostname validation things Want to know about upcoming build environment updates? Would you like to stay up-to-date with the upcoming Travis CI build environment updates? We set up a mailing list for you! Sign up here. Documentation about Travis CI Need help? Mail support! Choose who receives these build notification emails in your configuration file.
Would you like to test your private code? Travis CI for Private Projects could be your new best friend!
-- _,,,^..^,,,_ best, Eliot
Hi Nicolas,
On Thu, Aug 31, 2017 at 7:59 AM, Nicolas Cellier < nicolas.cellier.aka.nice@gmail.com> wrote:
2017-08-31 14:11 GMT+02:00 Nicolas Cellier <nicolas.cellier.aka.nice@gmai l.com>:
2017-08-31 10:59 GMT+02:00 Tobias Pape Das.Linux@gmx.de:
Hi Nicolas
On 31.08.2017, at 04:42, Nicolas Cellier <
nicolas.cellier.aka.nice@gmail.com> wrote:
2017-08-29 13:39 GMT+02:00 Tobias Pape Das.Linux@gmx.de:
Hi all,
currently the vm fails to build properly due to two main problems:
a) #testBecomeIdentityHash fails on Squeak5.1 for linux32x86 squeak.cog.spur https://travis-ci.org/OpenSmal
ltalk/opensmalltalk-vm/jobs/269505448#L3172
linux32x86 squeak.sista.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505458#L3208
linux32x86 squeak.stack.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505461#L1842
macos32x86 squeak.cog.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505499#L8455
macos32x86 squeak.sista.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505503#L8517
macos32x86 squeak.stack.spur https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505505#L7383
(Or said differently: on 32x86 for squeak.*.spur)
I recall we had problems there but I thought those were fixed 2..3
years ago?
Someone can comment?
It fails for more than 2 months (build #808) in any case in we look at
Travis history (i can't backtrack more than that)...
Did it ever work in spur? If I take VM from https://bintray.com/opensmalltalk/vm/cog, it worked until 201705281305 but 201706280928 fails.
The testBecomeIdentityHash did not change recently (it's from 2012)
Become had minor changes in July, so it's something before that... (only a new primitive for 1-way without copyHash has been added
recently...
and a primitive failure in case of immutability )
The problem must be somewhere between VMMaker.oscog-nice.2224 and
VMMaker.oscog-eem.2245
Thanks for bisecting that. I don't know hot to go on here, tho… Eliot, can you give me a pointer?
Best regards -tobias
Seeking for a narrower interval:
thess commit pass green: 6a63f68a3dd4deb7c17dd2c7ac6e4dd4b0b6d937 (comment: CogVM source as per VMMaker.oscog-eem.2232, May 31) 5ec678cdc4c1c2a66ef81b47762b7338d8ee81d1 (comment: CogVM source as per VMMaker.oscog-eem.2240, Jun 10) 9a98be0c6d5968627db24a3e4d97d0be28fba27c (comment: CogVm source as per VMMaker.oscog-eem.2241, Jun 10) b1bb2e26d0efe204b742681ba5674d9af57a4304 (comment: CogVM source as per VMMaker.oscog-eem.2242, Jun 13) db29f6214e325d97a245748aad27ff90b17e0e5c (comment: [osx] fix guard, again, Jun 15)
this commit fails red: 3010e4465405f6ec7a289fc3a3d21eb324816a8f (comment: CogVM source as per VMMaker.oscog-eem.2243, Jun 16)
VMMaker 2243 introduces a CodeGeneration change, so it's probably the cause and we'll have to analyze the diff of generated code...
Ah, ah, if I checkout 3010e4465405f6ec7a289fc3a3d21eb324816a8f and diff against parent git difftool --tool=sourcetree db29f6214e325d97a245748aad27ff90b17e0e5c spursrc/vm/cointerp.c (sourcedtree configured with winmerge) i get the interesting diff attached...
hash1 and hash2 are now type sqInt (32 bits on 32 bits VM) instead of sqLong (64 bits). So a type inference that did previously work no more does...
I've committed a fix to VMMaker.oscog. I'd appreciate your review. I've regenerated sources. Things look good now. Let's see what the CI says.
-- retry with attachment --
Nicolas
b) the pharo deployment seems to not work correctly:
https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505445#L1900
https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505471#L8223
https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505444#L1900
for 64x64 pharo.cog.spur. If it is correct that those 3 vms cannot be deployed, please fix the
deploy script to not try to.
IF incorrect, pleas fix on your side/site.
Best regards -Tobias
Begin forwarded message:
From: Travis CI builds@travis-ci.org Subject: Errored: OpenSmalltalk/opensmalltalk-vm#835 (Cog - 7dff211) Date: 29. August 2017 um 13:02:09 MESZ
OpenSmalltalk / opensmalltalk-vm (Cog)
Build #835 has errored. 48 minutes and 25 seconds Tobias Pape 7dff211 Changeset → [squeakssl] follow suit with the unix hostname validation
things
Want to know about upcoming build environment updates? Would you like to stay up-to-date with the upcoming Travis CI build
environment updates? We set up a mailing list for you! Sign up here.
Documentation about Travis CINeed help? Mail support! Choose who receives these build notification emails in your
configuration file.
Would you like to test your private code? Travis CI for Private Projects could be your new best friend!
2017-08-31 22:56 GMT+02:00 Eliot Miranda eliot.miranda@gmail.com:
Hi Nicolas,
On Thu, Aug 31, 2017 at 7:59 AM, Nicolas Cellier < nicolas.cellier.aka.nice@gmail.com> wrote:
2017-08-31 14:11 GMT+02:00 Nicolas Cellier <nicolas.cellier.aka.nice@gmai l.com>:
2017-08-31 10:59 GMT+02:00 Tobias Pape Das.Linux@gmx.de:
Hi Nicolas
On 31.08.2017, at 04:42, Nicolas Cellier <
nicolas.cellier.aka.nice@gmail.com> wrote:
2017-08-29 13:39 GMT+02:00 Tobias Pape Das.Linux@gmx.de:
Hi all,
currently the vm fails to build properly due to two main problems:
a) #testBecomeIdentityHash fails on Squeak5.1 for linux32x86 squeak.cog.spur
https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/26 9505448#L3172
linux32x86 squeak.sista.spurhttps://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/26 9505458#L3208
linux32x86 squeak.stack.spurhttps://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/26 9505461#L1842
macos32x86 squeak.cog.spurhttps://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/26 9505499#L8455
macos32x86 squeak.sista.spurhttps://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/26 9505503#L8517
macos32x86 squeak.stack.spurhttps://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/26 9505505#L7383
(Or said differently: on 32x86 for squeak.*.spur)
I recall we had problems there but I thought those were fixed 2..3
years ago?
Someone can comment?
It fails for more than 2 months (build #808) in any case in we look
at Travis history (i can't backtrack more than that)...
Did it ever work in spur? If I take VM from https://bintray.com/opensmalltalk/vm/cog, it worked until 201705281305 but 201706280928 fails.
The testBecomeIdentityHash did not change recently (it's from 2012)
Become had minor changes in July, so it's something before that... (only a new primitive for 1-way without copyHash has been added
recently...
and a primitive failure in case of immutability )
The problem must be somewhere between VMMaker.oscog-nice.2224 and
VMMaker.oscog-eem.2245
Thanks for bisecting that. I don't know hot to go on here, tho… Eliot, can you give me a pointer?
Best regards -tobias
Seeking for a narrower interval:
thess commit pass green: 6a63f68a3dd4deb7c17dd2c7ac6e4dd4b0b6d937 (comment: CogVM source as per VMMaker.oscog-eem.2232, May 31) 5ec678cdc4c1c2a66ef81b47762b7338d8ee81d1 (comment: CogVM source as per VMMaker.oscog-eem.2240, Jun 10) 9a98be0c6d5968627db24a3e4d97d0be28fba27c (comment: CogVm source as per VMMaker.oscog-eem.2241, Jun 10) b1bb2e26d0efe204b742681ba5674d9af57a4304 (comment: CogVM source as per VMMaker.oscog-eem.2242, Jun 13) db29f6214e325d97a245748aad27ff90b17e0e5c (comment: [osx] fix guard, again, Jun 15)
this commit fails red: 3010e4465405f6ec7a289fc3a3d21eb324816a8f (comment: CogVM source as per VMMaker.oscog-eem.2243, Jun 16)
VMMaker 2243 introduces a CodeGeneration change, so it's probably the cause and we'll have to analyze the diff of generated code...
Ah, ah, if I checkout 3010e4465405f6ec7a289fc3a3d21eb324816a8f and diff against parent git difftool --tool=sourcetree db29f6214e325d97a245748aad27ff90b17e0e5c spursrc/vm/cointerp.c (sourcedtree configured with winmerge) i get the interesting diff attached...
hash1 and hash2 are now type sqInt (32 bits on 32 bits VM) instead of sqLong (64 bits). So a type inference that did previously work no more does...
I've committed a fix to VMMaker.oscog. I'd appreciate your review. I've regenerated sources. Things look good now. Let's see what the CI says.
Hi Eliot, My most effective efforts so far were just at the level of a dumb bot: - activating checkout option in sourcetree commit history popup menu, - then repeating last shell command ./mvm -f; open `pwd`/Squeak.app - then running the sole preselected BecomeTest once the trunk50.image opened something like 4 clicks and 2 keystroke by commit :)
Every other thing I tried like reading VMMaker source, commit message, and diffs, IOW any action involving "understanding" failed. Tracking diffs is dumb enough though, so I can glance at the generated C and report if ever I see something.. Even the slightest contributions count :)
-- retry with attachment --
Nicolas
b) the pharo deployment seems to not work correctly:
https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505445#L1900
https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505471#L8223
https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505444#L1900
for 64x64 pharo.cog.spur. If it is correct that those 3 vms cannot be deployed, please fix the
deploy script to not try to.
IF incorrect, pleas fix on your side/site.
Best regards -Tobias
Begin forwarded message:
From: Travis CI builds@travis-ci.org Subject: Errored: OpenSmalltalk/opensmalltalk-vm#835 (Cog -
7dff211)
Date: 29. August 2017 um 13:02:09 MESZ
OpenSmalltalk / opensmalltalk-vm (Cog)
Build #835 has errored. 48 minutes and 25 seconds Tobias Pape 7dff211 Changeset → [squeakssl] follow suit with the unix hostname validation
things
Want to know about upcoming build environment updates? Would you like to stay up-to-date with the upcoming Travis CI build
environment updates? We set up a mailing list for you! Sign up here.
Documentation about Travis CINeed help? Mail support! Choose who receives these build notification emails in your
configuration file.
Would you like to test your private code? Travis CI for Private Projects could be your new best friend!
-- _,,,^..^,,,_ best, Eliot
Hi Nicolas,
On Sun, Sep 3, 2017 at 6:40 AM, Nicolas Cellier < nicolas.cellier.aka.nice@gmail.com> wrote:
2017-08-31 22:56 GMT+02:00 Eliot Miranda eliot.miranda@gmail.com:
Hi Nicolas,
On Thu, Aug 31, 2017 at 7:59 AM, Nicolas Cellier < nicolas.cellier.aka.nice@gmail.com> wrote:
2017-08-31 14:11 GMT+02:00 Nicolas Cellier < nicolas.cellier.aka.nice@gmail.com>:
2017-08-31 10:59 GMT+02:00 Tobias Pape Das.Linux@gmx.de:
Hi Nicolas
On 31.08.2017, at 04:42, Nicolas Cellier <
nicolas.cellier.aka.nice@gmail.com> wrote:
2017-08-29 13:39 GMT+02:00 Tobias Pape Das.Linux@gmx.de:
Hi all,
currently the vm fails to build properly due to two main problems:
a) #testBecomeIdentityHash fails on Squeak5.1 for linux32x86 squeak.cog.spur
https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/26 9505448#L3172
linux32x86 squeak.sista.spurhttps://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/26 9505458#L3208
linux32x86 squeak.stack.spurhttps://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/26 9505461#L1842
macos32x86 squeak.cog.spurhttps://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/26 9505499#L8455
macos32x86 squeak.sista.spurhttps://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/26 9505503#L8517
macos32x86 squeak.stack.spurhttps://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/26 9505505#L7383
(Or said differently: on 32x86 for squeak.*.spur)
I recall we had problems there but I thought those were fixed 2..3
years ago?
Someone can comment?
It fails for more than 2 months (build #808) in any case in we look
at Travis history (i can't backtrack more than that)...
Did it ever work in spur? If I take VM from https://bintray.com/opensmalltalk/vm/cog, it worked until 201705281305 but 201706280928 fails.
The testBecomeIdentityHash did not change recently (it's from 2012)
Become had minor changes in July, so it's something before that... (only a new primitive for 1-way without copyHash has been added
recently...
and a primitive failure in case of immutability )
The problem must be somewhere between VMMaker.oscog-nice.2224 and
VMMaker.oscog-eem.2245
Thanks for bisecting that. I don't know hot to go on here, tho… Eliot, can you give me a pointer?
Best regards -tobias
Seeking for a narrower interval:
thess commit pass green: 6a63f68a3dd4deb7c17dd2c7ac6e4dd4b0b6d937 (comment: CogVM source as per VMMaker.oscog-eem.2232, May 31) 5ec678cdc4c1c2a66ef81b47762b7338d8ee81d1 (comment: CogVM source as per VMMaker.oscog-eem.2240, Jun 10) 9a98be0c6d5968627db24a3e4d97d0be28fba27c (comment: CogVm source as per VMMaker.oscog-eem.2241, Jun 10) b1bb2e26d0efe204b742681ba5674d9af57a4304 (comment: CogVM source as per VMMaker.oscog-eem.2242, Jun 13) db29f6214e325d97a245748aad27ff90b17e0e5c (comment: [osx] fix guard, again, Jun 15)
this commit fails red: 3010e4465405f6ec7a289fc3a3d21eb324816a8f (comment: CogVM source as per VMMaker.oscog-eem.2243, Jun 16)
VMMaker 2243 introduces a CodeGeneration change, so it's probably the cause and we'll have to analyze the diff of generated code...
Ah, ah, if I checkout 3010e4465405f6ec7a289fc3a3d21eb324816a8f and diff against parent git difftool --tool=sourcetree db29f6214e325d97a245748aad27ff90b17e0e5c spursrc/vm/cointerp.c (sourcedtree configured with winmerge) i get the interesting diff attached...
hash1 and hash2 are now type sqInt (32 bits on 32 bits VM) instead of sqLong (64 bits). So a type inference that did previously work no more does...
I've committed a fix to VMMaker.oscog. I'd appreciate your review. I've regenerated sources. Things look good now. Let's see what the CI says.
Hi Eliot, My most effective efforts so far were just at the level of a dumb bot:
- activating checkout option in sourcetree commit history popup menu,
- then repeating last shell command ./mvm -f; open `pwd`/Squeak.app
- then running the sole preselected BecomeTest once the trunk50.image
opened something like 4 clicks and 2 keystroke by commit :)
Every other thing I tried like reading VMMaker source, commit message, and diffs, IOW any action involving "understanding" failed. Tracking diffs is dumb enough though, so I can glance at the generated C and report if ever I see something.. Even the slightest contributions count :)
It was a vary valuable contribution. What we need, I suppose, are some good type inference tests.
-- retry with attachment --
Nicolas
b) the pharo deployment seems to not work correctly:
https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505445#L1900
https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505471#L8223
https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/jobs/269505444#L1900
for 64x64 pharo.cog.spur. If it is correct that those 3 vms cannot be deployed, please fix the
deploy script to not try to.
IF incorrect, pleas fix on your side/site.
Best regards -Tobias
> Begin forwarded message: > > From: Travis CI builds@travis-ci.org > Subject: Errored: OpenSmalltalk/opensmalltalk-vm#835 (Cog -
7dff211)
> Date: 29. August 2017 um 13:02:09 MESZ > > OpenSmalltalk / opensmalltalk-vm (Cog) > > Build #835 has errored. 48 minutes and 25 seconds > Tobias Pape 7dff211 Changeset → > [squeakssl] follow suit with the unix hostname validation
things
> Want to know about upcoming build environment updates? > Would you like to stay up-to-date with the upcoming Travis CI
build environment updates? We set up a mailing list for you! Sign up here.
> Documentation about Travis CI > Need help? Mail support! > Choose who receives these build notification emails in your
configuration file.
> > Would you like to test your private code? > Travis CI for Private Projects could be your new best friend!
-- _,,,^..^,,,_ best, Eliot
vm-dev@lists.squeakfoundation.org
-
Eliot Miranda -
Nicolas Cellier -
Tobias Pape