[etoys-dev] Etoys Inbox: Graphics-wiz.7.mcz

[commits at source.squeak.org]

A new version of Graphics was added to project Etoys Inbox:
http://source.squeak.org/etoysinbox/Graphics-wiz.7.mcz

==================== Summary ====================

Name: Graphics-wiz.7
Author: wiz
Time: 10 August 2010, 12:16:30 am
UUID: ba4cea20-8b6a-460f-9fd6-d610f55dec6e
Ancestors: Graphics-bf.6

This is part of the targeting changes.

For lack of a better plan I am including the preamble from the change set in each of these headers.

There are four changes here
Three to Cursor class to define a James Bondish targeting cursor.
One to Point class to allow specifing a cursor as a point is obtained.

This one wants to be loaded first as it doesn't depend on the other parts and the other parts will depend on it.

Note: When I loaded this I got a primitive fail as it tried to initialize the cursor with mask. I don't yet know what that is about but just proceeding past it get the cursor defined anyway. Maybe the mask is missing. This is something that can be fixed later so not a reason to delay this change.

The rest of the change set preamble follows for completeness:

"Change Set:		targetOffsetFixes-wiz
Date:			5 June 2007
Author:			(wiz) Jerome Peace

wiz 6/6/2007 23:41 6/6/2007 23:41

filed in the button and menu targetsighting fixes. 
This stuff needs to be checked and fleshed out.
Todo: #sightWorldTargets: has no senders yet it is very important. (and possibly should replace #sightTargets:).
Check to see if Morph level #target: backup is in place. 



wiz 6/5/2007 22:44

added fix for tilted target.

wiz 6/5/2007 21:15

added target cursor in targeting


wiz 6/5/2007 20:53

adjusted #setTarget: to refer to evt targetPoint instead of evt hand targetPoint. 

wiz 6/5/2007 20:48

added target cursor to cursor class.

added Point class>>fromUserWithCursor:


wiz 6/5/2007 20:22

Compilation of fixes for 3.8 (as of update 0556)
This first is just the fixes from the changeset below. Mostly changes targetOffset (when misused) to targetPoint.





Change Set:		TargetOffsetFix-wiz
Date:			4 December 2006
Author:			(wiz) Jerome Peace

wiz 12/4/2006 00:43

Second fix up the offending senders.

wiz 12/4/2006 00:12

Start repairs for targetOffset misuse.
Mantis #5567.

First add targetPoint to HandMorph.

"


=============== Diff against Graphics-bf.6 ===============

Item was added:
+ ----- Method: Point class>>fromUserWithCursor: (in category 'instance creation') -----
+ fromUserWithCursor: aCursor
+ 	Sensor waitNoButton .
+ 	aCursor showWhile: [ Sensor waitButton ] .
+ 	^ Sensor cursorPoint
+ 
+ "Point fromUserWithCursor: Cursor target"
+ "Point fromUserWithCursor: Cursor crossHair"
+ !

Item was changed:
  ----- Method: Cursor class>>initialize (in category 'class initialization') -----
  initialize
  	"Create all the standard cursors..."
+ 	self initOrigin.
+ 	self initRightArrow.
+ 	self initMenu.
+ 	self initCorner.
+ 	self initRead.
+ 	self initWrite.
+ 	self initWait.
+ 	BlankCursor := Cursor new.
+ 	self initXeq.
+ 	self initSquare.
+ 	self initNormalWithMask.
+ 	self initCrossHair.
+ 	self initMarker.
+ 	self initUp.
+ 	self initDown.
+ 	self initMove.
+ 	self initBottomLeft.
+ 	self initBottomRight.
+ 	self initResizeLeft.
+ 	self initResizeTop.
+ 	self initResizeTopLeft.
+ 	self initResizeTopRight.
+ 	self initTopLeft.
+ 	self initTopRight.
+ 	self initTarget.
+ 	self makeCursorsWithMask!
- 		self initOrigin.
- 		self initRightArrow.
- 		self initMenu.
- 		self initCorner.
- 		self initRead.
- 		self initWrite.
- 		self initWait.
- 		BlankCursor _ Cursor new.
- 		self initXeq.
- 		self initSquare.
- 		self initNormalWithMask.
- 		self initCrossHair.
- 		self initMarker.
- 		self initUp.
- 		self initDown.
- 		self initMove.
- 		self initBottomLeft.
- 		self initBottomRight.
- 		self initResizeLeft.
- 		self initResizeTop.
- 		self initResizeTopLeft.
- 		self initResizeTopRight.
- 		self initTopLeft.
- 		self initTopRight.
- 		self makeCursorsWithMask.
- 
- 		"Cursor initialize"
- !

Item was added:
+ ----- Method: Cursor class>>initTarget (in category 'class initialization') -----
+ initTarget
+ 	TargetCursor := Cursor
+ 				extent: 16 @ 16
+ 				fromArray:  #(1984 6448 8456 16644 17284 33026 35106 65278 35106 33026 17284 16644 8456 6448 1984 0)
+ 				offset: -7 @ -7!

Item was added:
+ ----- Method: Cursor class>>target (in category 'constants') -----
+ target
+ 	"Answer the instance of me that is the shape of a gunsight."
+ 	"Cursor target show"
+ 	^ TargetCursor!