[etoys-dev] Etoys: Tools-kfr.14.mcz

[karl ramberg]

On Thu, Dec 13, 2012 at 4:05 PM, Bert Freudenberg <bert at freudenbergs.de>wrote:

>
> On 2012-12-13, at 07:59, commits at source.squeak.org wrote:
>
> > Karl Ramberg uploaded a new version of Tools to project Etoys:
> > http://source.squeak.org/etoys/Tools-kfr.14.mcz
> >
> > ==================== Summary ====================
> >
> > Name: Tools-kfr.14
> > Author: kfr
> > Time: 13 December 2012, 8:59:15 am
> > UUID: ca9017f6-5c84-284c-a508-fbabbe39c1dd
> > Ancestors: Tools-kfr.13
> >
> > A little better conversion of tiles to code
> >
> > =============== Diff against Tools-kfr.13 ===============
> >
> > Item was changed:
> >  ----- Method: MethodHolder>>acceptDroppingMorph:event:inMorph: (in
> category 'drag and drop') -----
> >  acceptDroppingMorph: dropee event: evt inMorph: targetMorph
> >       "Return the dropee to its old position, and add a reference to it
> at the cursor point."
> >       | externalName |
> >       (dropee isTileLike)
> >                               ifTrue:[dropee isTileMorph
> > +                                                     ifFalse:[
> externalName := dropee codeString unparenthetically]
> > -                                                     ifFalse:[^dropee
> rejectDropMorphEvent: evt. ]
> >
> ifTrue:[externalName := dropee actualObject uniqueNameForReference]]
> >                               ifFalse:[externalName := dropee
> assuredPlayer uniqueNameForReference].
> >       targetMorph correctSelectionWithString: externalName.
> >       dropee rejectDropMorphEvent: evt.
> >       ^ true "success"
> >  !
>
>
> It's a bit misleading that you call the temp var "externalName" because
> the #externalName message returns the user-visible name of a player, not
> the unique name for reference. They are sometimes the same, but sometimes
> not. "referenceName" would be better.
>

Thanks for the plug.
Copy-paste of code without reflection from my side caused this error.
I'll fix it

Karl

>
> - Bert -
>
>

>
> _______________________________________________
> etoys-dev mailing list
> etoys-dev at squeakland.org
> http://lists.squeakland.org/mailman/listinfo/etoys-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakland.org/pipermail/etoys-dev/attachments/20121214/66e351c4/attachment.html>