[etoys-dev] [squeakland] Calendar fixes

[Scott Wallace]

Hi, Richo,

On Jan 4, 2012, at 9:00 AM, Ricardo Moran wrote:

> Important for developers: I changed the way the locale changes are notified to morphs. See Project>>#updateLocaleDependentsWithPreviousSupplies:gently: and Morph>>#localeChanged. Basically, I just send #localeChanged to all morphs and I have the default implementation in Morph doing nothing. I think this is much better than before because now any morph can get notified of locale changes by just implementing the #localeChanged method, but I wanted to ask for your opinion on this.

This seems a good thing -- much cleaner.

One thing that seems to be lost in your implementation however is that the existing code goes out of its way to defer the "localeChanged" sends for all top-level ScriptEditorMorphs until all the #localChanged sends have completed for morphs that are *not* top-level ScriptEditorMorphs.

I'm not 100% certain that this logic is still necessary, but obviously it was once necessary, probably for some infrequently-seen combination of conditions, and retaining the logic does no real harm, so I suggest that it not be discarded.  A small change to your method could preserve the existing order without losing the benefits of your improvement; I attach a little change-set incorporating that change for your consideration :)

Thank you!

  -- Scott


-------------- next part --------------
A non-text attachment was scrubbed...
Name: updateLocale-sw.3.cs.gz
Type: application/x-gzip
Size: 776 bytes
Desc: not available
URL: <http://lists.squeakland.org/pipermail/etoys-dev/attachments/20120111/5650a25b/attachment.gz>