[etoys-dev] [squeakland] Calendar fixes

[Ricardo Moran]

On Wed, Jan 11, 2012 at 11:01 PM, Scott Wallace <
scott.wallace at squeakland.org> wrote:

> Hi, Richo,
>
> On Jan 4, 2012, at 9:00 AM, Ricardo Moran wrote:
>
> > Important for developers: I changed the way the locale changes are
> notified to morphs. See
> Project>>#updateLocaleDependentsWithPreviousSupplies:gently: and
> Morph>>#localeChanged. Basically, I just send #localeChanged to all morphs
> and I have the default implementation in Morph doing nothing. I think this
> is much better than before because now any morph can get notified of locale
> changes by just implementing the #localeChanged method, but I wanted to ask
> for your opinion on this.
>
> This seems a good thing -- much cleaner.
>
> One thing that seems to be lost in your implementation however is that the
> existing code goes out of its way to defer the "localeChanged" sends for
> all top-level ScriptEditorMorphs until all the #localChanged sends have
> completed for morphs that are *not* top-level ScriptEditorMorphs.
>

Yes, you're right. I didn't notice the order.


>
> I'm not 100% certain that this logic is still necessary, but obviously it
> was once necessary, probably for some infrequently-seen combination of
> conditions, and retaining the logic does no real harm, so I suggest that it
> not be discarded.  A small change to your method could preserve the
> existing order without losing the benefits of your improvement; I attach a
> little change-set incorporating that change for your consideration :)
>

Thanks, I'll commit the changes to etoys :)

Cheers,
Richo


>
> Thank you!
>
>  -- Scott
>
>
>
> _______________________________________________
> etoys-dev mailing list
> etoys-dev at squeakland.org
> http://lists.squeakland.org/mailman/listinfo/etoys-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakland.org/pipermail/etoys-dev/attachments/20120113/8cdb322b/attachment.html>