[Morphic] Nebraska removal

[Juan Vuletich]

Hi Edgar.

I revised your code and I have some comments that I hope will be useful for 
you.

1) Your changes include code that would outside our packages. As I 
understand it, I can only publish new versions of our packages.

2) On ClassDescription >> allMethodsInCategorybeginsWith:
 - The method comment makes no sense to me
 - aName should be called prefix
 - The selector could better be allMethodsInCategorybeginningWith: but such 
a long selector is ugly too.
 - The variable categorybeginsWith should be called categoriesbeginningWith 
(The names are very important, and should be in proper English)
 - Where you do "select: [:c | c beginsWith: aName] thenCollect: [:any | 
any]." the thenCollect: is not needed
 - Anyway, it's better not to create the categorybeginsWith collection. It 
is not needed.
 - You create an OrderedCollection only to later make it a Set
 - aColl is an ugly name
I believe that code that goes to the official image deserves more care and 
thought.

3) I'd rather not add any of the #allMethodsInCategorybeginsWith: you add. 
They are actually not needed. #unloadNebraska is not needed either. If I 
remove the senders of #remoteCanvasesDo:, then I can unload Nebraska cleanly 
from the package browser. I believe we should try to remove redundant stuff, 
and not add more!

4) NebraskaWorldState >> forceDamageToScreen: . The comment makes no sense

5) I don't see the means to actually use NebraskaWorldState. I don't see the 
means to migrate existing instances between NebraskaWorldState and 
WorldState.

I understand these comments might sound a bit harsh, and I apologize. But I 
believe you can do better!

Cheers,
Juan
----- Original Message ----- 

From: "Lic. Edgar J. De Cleene" <edgardec2001 at yahoo.com.ar>
To: <morphic at lists.squeakfoundation.org>
Sent: Wednesday, December 28, 2005 8:34 AM
Subject: [Morphic] Nebraska removal


>I hope this address the previous questions by Cees and Juan.
>
> Edgar
>
>


--------------------------------------------------------------------------------


> _______________________________________________
> Morphic mailing list
> Morphic at lists.squeakfoundation.org
> http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/morphic
>


--------------------------------------------------------------------------------


No virus found in this incoming message.
Checked by AVG Free Edition.
Version: 7.1.371 / Virus Database: 267.14.7/214 - Release Date: 12/23/2005