[Seaside-dev] Seaside2.8a1-mb.506

[Philippe Marschall]

2007/10/18, Michel Bany <michel.bany at gmail.com>:
> Hi Philippe,
>
> Seaside2.8a1-mb.507 has the test, freshly baked.
> It doesn't detect any subtle effect in Kom, as far as I could see.
>
> Of course, I'm not "really sure" this breaks nothing, this is
> software after all.
> I'm just confident, and a little more confident now that we have the
> test.
>
> I did some research and found out that this code was there already in
> 2.5a,
> At that time (april 2004) WADocumentHandler was only used for supporting
> the #style and #script methods. Now that it also supports pictures,
> sending
> #text doesn't really make sense when the stream is on a byte array.
> The fact
> that it was working although #text was sent is a reasonable
> indication that
> sending #text was indeed useless.

Makes sense to me, no let's hope it makes sense to Squeak as well ;)
And thanks for the test.

Cheers
Philippe

> Cheers,
> Michel.
>
>
> On Oct 17, 2007, at 9:24 PM, Philippe Marschall wrote:
>
> > Are you really sure this breaks nothing? This is a good candidate for
> > a subtle bug. Previously the content stream was always in text mode.
> > Now this is no longer the case of the content is a byte array. This
> > could as well be a bug as a fix. I can't tell what the correct
> > behviour should be. A test would be appreciated. Would #ascii be
> > acceptable as a way to restore the old behavior?
> >
> > Philippe
> > _______________________________________________
> > seaside-dev mailing list
> > seaside-dev at lists.squeakfoundation.org
> > http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>
> _______________________________________________
> seaside-dev mailing list
> seaside-dev at lists.squeakfoundation.org
> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>