[Seaside-dev] Seaside2.8a1-mb.508

[Philippe Marschall]

2007/10/18, Michael Lucas-Smith <mlucas-smith at cincom.com>:
> Michel Bany wrote:
> >
> > On Oct 18, 2007, at 8:04 PM, Philippe Marschall wrote:
> >
> >> SeasidePlatformSupport>>ifDefined:do: has no senders at all in
> >> Seaside. If you only use it in VW I suggest you include it only in VW.
> >
> > It has a sender in a Seaside add-on (SeasideAsync).
> >
> This change was an effort toward the code freezeness actually

The freeze was two months ago. As far as I am concered this amout of
changes you guys rush in on the finish line seriously endagers a
timely 2.8 release. The idea of the freeze was to give code a time to
sabilize and fix bugs, not to add features.

> we want
> Seaside and its commonly used components to load cleanly in to Cincom
> Smalltalk without undeclareds and undefineds, etc. In this case, Async
> can depend on Scriptaculous if Scriptaculous is loaded. We cannot
> introduce the Cincom Smalltalk #{} syntax for variable bindings, so
> instead we pushed it to the "platform compatibility" layer -
> SeasidePlatformSupport.

Huh? If I look at I see it only used in one place, this is importing
JavaScripts and to quote form the code it is a:
"Naughty, dirty, awful hack"
We are not talking about having parts that use Scriptcaculous and
other that don't. If you have that, just make two packages and one
depend on Scriptcaculous.

Now about the other user of #ifDefined:do: that should be a test for
WAKom. WADocumentHandlerTest should only test the Seaside side.

We should strive toward making SeasidePlatformSupport smaller, not bigger.

To sum it I don't see the need for #ifDefined:do:

Cheers
Philippe