[Seaside-dev] Seaside2.8a1-rew.514

[Roger Whitney]

Philippe,
	Thanks for the improvements. I was in a hurry to get these out  
before leaving for OOPSA.

	I am still not happy with the class comment for WALRUCIache. The  
cache can grow to an arbitrary size, which is not what I would  
consider a normal feature of  cache. The class comment does not  
convey that. I like the following better:

WALRUCache implements at Least Recently Used cache. Items are removed  
from the cache when they reach "max" age. The age of an item is the  
number of additions to the cache done since the item itself was added  
or last accessed. Given the proper set of accesses and adds the cache  
can become arbitraryly large. The "capacity:" method is misleading,  
it sets the at which items are removed from the cache not the number  
of items allowed in the cache.

On Oct 20, 2007, at 5:37 PM, Philippe Marschall wrote:

> The usual, almost expected high quality of comments. I only had to
> change some minor things like that WALRUCache is used to store the
> last n continuations of a session, WADocumentHandler can handle
> anything that understands #asMIMEDocumentType: and more explitly
> explain the behavior of useSessionCookie. I thought I once added a
> very helpful comment to WAProcessMonitor but I must have dreamed that.
>
> Thanks for all the hard work.
>
> Cheers
> Philippe
> _______________________________________________
> seaside-dev mailing list
> seaside-dev at lists.squeakfoundation.org
> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>



----
Roger Whitney              Department of Computer Science
whitney at cs.sdsu.edu        San Diego State University
http://www.eli.sdsu.edu/   San Diego, CA 92182-7720