[Seaside-dev] Issue 337 in seaside: Move #register*Callback: methods to WARenderer

[codesite-noreply at google.com]

Status: Accepted
Owner: ----
Labels: Type-CleanUp Priority-Medium Bite-Size

New issue 337 by jfitzell: Move #register*Callback: methods to WARenderer
http://code.google.com/p/seaside/issues/detail?id=337

Currently there about about 10 #renderSomethingCallback: methods on
WACallbackRegistry, each of which simply calls "self storeCallback:" with
an instance of the appropriate class.

Excluding tests of WACallbackRegistry itself, *every* sender of these
methods is of the form "aCanvas callbacks registerSomethingCallback".

Additionally, almost every sender of #callbacks is of the form "aCanvas
callbacks registerSomethingCallback".

Since all Renderers have a RenderContext and all RenderContexts have a
CallbackRegistry, I suggest we move these methods onto WARenderer. This
will eliminate having to send #callbacks everywhere and mean that Renderers
have the opportunity to override the type of callback that is registered
(there is currently no easy way to specify that a subclass of
WACallbackRegistry be used).

Existing implementations could possibly be left as "deprecated" if desired,
though they would have to duplicate the implementation.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings