[Seaside-dev] Issue 304 in seaside: caching session cookie state

[codesite-noreply at google.com]

Status: Accepted
Owner: ----
Labels: Type-Defect Priority-Low Version-Seaside2.9

New issue 304 by jfitzell: caching session cookie state
http://code.google.com/p/seaside/issues/detail?id=304

I wonder whether the current session cookie implementation using the
"cookiesEnabled" instvar is ideal.

We're talking about edge cases here, but it seems like you could have the
following situation:
  + Start a new session
  + You have the cookie added
  + You copy a link on the page
  + You click on a link
  + "cookiesEnabled" is set to true
  + you close your browser
  + you reopen the browser
  + you paste the copied link
  + the session thinks you have the cookie but you don't

It seems like nicer behaviour would be to always add the cookie if it isn't
already there.

Presumably this it not done in order to avoid calling #sessionCookieFor:
too many times. But #sessionCookieFor: is already called in the Application
when looking up the session. What if we cached the session cookie at that
point in the request context property dictionary? Or, now that I think
about it, couldn't the Application just add the cookie at that point if it
isn't present? (depends if we need that behaviour to be customizable by
subclassing Session, I guess)

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings