[Seaside-dev] Seaside-Tests-ANSI Package

[Philippe Marschall]

+1

2009/1/31 Julian Fitzell <jfitzell at gmail.com>:
> I already posted something about this (presumably in the issue
> discussing it). I don't see any value at all in having random ANSI
> tests for behaviour that (a) we don't use and (b) doesn't pass on
> several platforms (including Squeak). I really don't want to stare at
> a red test bar all the time. As far as I'm concerned, if these
> behaviours don't pass on most of our ported platforms we can't use
> them anyway, so whether they are ANSI standard or not is irrelevant.
>
> Sure, let's document it somewhere so we can push the various platforms
> to make sure they support it eventually. But in the meantime, let's
> just document them as portability issues, not use them, and not stare
> at failing tests for the rest of eternity.
>
> Julian
>
> On Fri, Jan 30, 2009 at 10:36 PM, Lukas Renggli <renggli at gmail.com> wrote:
>> I wonder about the package Seaside-Tests-ANSI: It contains two test
>> methods related to stream positioning in their own test case, while
>> all the rest of the related ANSI stream test remain in the class
>> WAPlatformTests in Seaside-Tests-Platform.
>>
>> I assume that this change was made because a single platform does not
>> pass these two tests. Does that mean that because Squeak/Pharo is the
>> only platform where WAPlatformTests>>#testReadStreamIsEmpty fails,
>> this test has to be brushed under the carpet into Seaside-Tests-ANSI?
>> This seems totally weird to me.
>>
>> We will soon end up with a packaging chaos and everybody will randomly
>> move around methods depending on whether they pass or not. Not seeing
>> that a test fails defeats the purpose of testing. This is cheating.
>>
>> In order of personal preference I see 3 possible solutions:
>>
>> 1. Move the 2 tests back to Seaside-Tests-Platform.
>>
>> 2. Move all the ANSI related tests to Seaside-Tests-ANSI. However,
>> there is already an ANSI test-suite and I would like to avoid
>> duplicating that effort
>> (http://map1.squeakfoundation.org/sm/package/d7011055-4446-4b8e-b6da-e7e32d3389ec).
>>
>> 3. Delete the 3 tests #testReadStreamPosition,
>> #testWriteStreamPosition and #testReadStreamIsEmpty, as they seem to
>> test functionality that is not currently in use Seaside. This is at
>> the risk that suddenly somebody uses these common methods and finds
>> them broken on some platforms.
>>
>> Thoughts?
>>
>> Lukas
>>
>> --
>> Lukas Renggli
>> http://www.lukas-renggli.ch
>> _______________________________________________
>> seaside-dev mailing list
>> seaside-dev at lists.squeakfoundation.org
>> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>>
> _______________________________________________
> seaside-dev mailing list
> seaside-dev at lists.squeakfoundation.org
> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>