[Seaside-dev] Re: [Seaside Commits] Seaside 3.0: Grease-Core-obi.29.mcz

[Julian Fitzell]

I tried having subclasses when I did the Pier and Magritte ports but
it was a pain because you couldn't resolve dependencies from, say,
Magritte packages on Seaside packages.

There used to be a method on WADevelopment that returned the Seaside
packages - seems lukas refactored it away. :) Perhaps we could just
add something like that back?

Can we revert the change that began this discussion in the meantime?
This isn't the highest priority and I think Lukas is right that
#urlSelector is a poor interface (it isn't always a selector).

Julian

On Sun, Feb 21, 2010 at 10:48 PM, Gerhard Obermann <obi068 at gmail.com> wrote:
> WADevelopment loadPackages: WADevelopment allPackages
>
> always loads all packages currently defined in GRPackage.
> Mostly I dont want to update all packages at the same time.
>
> E.g. I would prefer to update only the seaside core packages,
> and not e.g. Magritte or some seaside addOns.
> So adding an instVar to GRPackage would be an option.
> Or maybe adding a subclass to GRPackage.
>
> Gerhard
>
>
>
>
> On Sun, Feb 21, 2010 at 11:12 PM, Julian Fitzell <jfitzell at gmail.com> wrote:
>>
>> Yeah, just because it's being stored in the Seaside repo, doesn't mean
>> it's a "seaside basic package" and, conversely, some seaside packages
>> are not in that repo.
>>
>> If this is really needed, we should add proper meta-data that
>> specifies a group or a project or something. But I'm still not really
>> happy with WAPackage and reluctant to keep adding functionality to it.
>> :)
>>
>> Julian
>>
>> On Sun, Feb 21, 2010 at 2:07 PM, Lukas Renggli <renggli at gmail.com> wrote:
>> > What about
>> >
>> >   WADevelopment loadPackages: WADevelopment allPackages
>> >
>> > ?
>> >
>> > We should not misuse internal state for unrelated things. This
>> > happened before with the license that was used to find the the
>> > repository URL, which was really ugly to fix.
>> >
>> > Lukas
>> >
>> > On 21 February 2010 20:43, Gerhard Obermann <obi068 at gmail.com> wrote:
>> >> Because I want to do something like this:
>> >>
>> >> WADevelopment allPackages select: [:each | each urlSelector =
>> >> #seasideUrl ]
>> >>
>> >> I need all seaside basic packages to be able to update the packages
>> >> using
>> >> Gofer.
>> >>
>> >> Gerhard
>> >>
>> >> On Sun, Feb 21, 2010 at 6:56 PM, Lukas Renggli <renggli at gmail.com>
>> >> wrote:
>> >>>
>> >>> Is there a particular reason that you added this method?
>> >>>
>> >>> As you can see in the method comment of #url: the variable can also
>> >>> contain a string, so your method does not necessarily return what it
>> >>> says.
>> >>>
>> >>> Also consider adding a method comment and tests for any public method.
>> >>>
>> >>> Lukas
>> >>>
>> >>> On 21 February 2010 18:41,
>> >>> <squeak-dev-noreply at lists.squeakfoundation.org> wrote:
>> >>> > Gerhard Obermann uploaded a new version of Grease-Core to project
>> >>> > Seaside 3.0:
>> >>> > http://www.squeaksource.com/Seaside30/Grease-Core-obi.29.mcz
>> >>> >
>> >>> > ==================== Summary ====================
>> >>> >
>> >>> > Name: Grease-Core-obi.29
>> >>> > Author: obi
>> >>> > Time: 21 February 2010, 6:43:17 pm
>> >>> > UUID: 79473ec4-083e-a144-aa40-4d100d2ab1e3
>> >>> > Ancestors: Grease-Core-lr.28
>> >>> >
>> >>> > - add direct accessing method for url
>> >>> >
>> >>> > =============== Diff against Grease-Core-lr.28 ===============
>> >>> >
>> >>> > Item was added:
>> >>> > + ----- Method: GRPackage>>urlSelector (in category 'accessing')
>> >>> > -----
>> >>> > + urlSelector
>> >>> > +       ^ url!
>> >>> >
>> >>> >
>> >>> > _______________________________________________
>> >>> > commits mailing list
>> >>> > To unsubscribe, email commits-leave at lists.seaside.st
>> >>> > http://lists.seaside.st/listinfo/commits
>> >>> >
>> >>>
>> >>>
>> >>>
>> >>> --
>> >>> Lukas Renggli
>> >>> http://www.lukas-renggli.ch
>> >>> _______________________________________________
>> >>> seaside-dev mailing list
>> >>> seaside-dev at lists.squeakfoundation.org
>> >>> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>> >>
>> >>
>> >> _______________________________________________
>> >> seaside-dev mailing list
>> >> seaside-dev at lists.squeakfoundation.org
>> >> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>> >>
>> >>
>> >
>> >
>> >
>> > --
>> > Lukas Renggli
>> > http://www.lukas-renggli.ch
>> > _______________________________________________
>> > seaside-dev mailing list
>> > seaside-dev at lists.squeakfoundation.org
>> > http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>> >
>> _______________________________________________
>> seaside-dev mailing list
>> seaside-dev at lists.squeakfoundation.org
>> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>
>
> _______________________________________________
> seaside-dev mailing list
> seaside-dev at lists.squeakfoundation.org
> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>
>