[Seaside-dev] improving rendering performance (on Pharo)

[Paolo Bonzini]

On Fri, May 21, 2010 at 13:35, Philippe Marschall
<philippe.marschall at gmail.com> wrote:
> 2010/5/21 Julian Fitzell <jfitzell at gmail.com>:
>> On Fri, May 21, 2010 at 8:46 AM, Philippe Marschall
>> <philippe.marschall at gmail.com> wrote:
>>>
>>> 2010/5/21 Julian Fitzell <jfitzell at gmail.com>:
>>> > So when you say hacked in, you mean I should try not to include these
>>> > versions this weekend? :)
>>>
>>> No, by all means include it so that it gets tested. What I mean is the
>>> code is probably not going to stay in the state it is currently in.
>>> Which doesn't matter so much for Pharo but matters for everybody else
>>> who wants to build an optimized implementation for his platform.
>>>
>>> The end result is methods on platform for escaping xml and urls with
>>> the current code the default implementation on GRPlatform.

I think "^true" will be faster for the default platform, especially for
#includesUnsafeUrlCharacter:  If you interpret that as the method
having false positives, but not false negatives, you can even
keep some testcases.

With this change I have no reason to complain about this optimization.

Paolo