[Seaside-dev] commit messages

[Julian Fitzell]

On Mon, Jun 20, 2011 at 4:50 PM, Nick Ager <nick.ager at gmail.com> wrote:

> Looking at the code I've just committed:
>
> Name: Seaside-Session-NickAger.139
>
> Author: NickAger
>
> Time: 20 June 2011, 3:51:59 pm
>
> UUID: ad79427b-c248-4194-8c18-8207969a74a7
>
> Ancestors: Seaside-Session-pmm.138
>
>
>> fix for http://code.google.com/p/seaside/issues/detail?id=659
>
>
>> when request isPrefetch, WAApplication>>handleFiltered: DNUs with
>> WAResponseGenerator>>doesNotUnderstand: #statusForbidden.
>
>
> Presumably this is OK? However I guess my test check-in wasn't clear as I
> copy and pasted:
>

Well, I'm not sure. There was a DNU.... so how did you fix it? Did you add
the method somewhere? Change the sender to avoid sending it? Fix a bug that
was resulting in the method being called on the wrong receiver?


>  Name: Seaside-Tests-Session-NickAger.45
>
> Author: NickAger
>
> Time: 20 June 2011, 3:50:58 pm
>
> UUID: 6e63c856-6791-4a8f-b7be-8d864e29f39c
>
> Ancestors: Seaside-Tests-Session-pmm.44
>
>
>> fix for http://code.google.com/p/seaside/issues/detail?id=659
>
>
>> when request isPrefetch, WAApplication>>handleFiltered: DNUs with
>> WAResponseGenerator>>doesNotUnderstand: #statusForbidden.
>
>
> and should have read something like:
>
>  added WAApplicationTest>>testPreFetchIsForbidden to test
>> http://code.google.com/p/seaside/issues/detail?id=659
>
>
I'm less concerned about test commits... if what the test tests is
interesting, mention it. Probably in this case a pointer to the issue is
fine (particularly if the issue at least points to a package commit that has
a description of what the fix was).

Julian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/seaside-dev/attachments/20110620/76e4380f/attachment-0001.htm