[Seaside-dev] commit messages

Philippe Marschall philippe.marschall at gmail.com
Mon Jun 20 16:57:49 UTC 2011


2011/6/20 Julian Fitzell <jfitzell at gmail.com>:
>
>
> On Mon, Jun 20, 2011 at 4:50 PM, Nick Ager <nick.ager at gmail.com> wrote:
>>
>> Looking at the code I've just committed:
>>>
>>> Name: Seaside-Session-NickAger.139
>>>
>>> Author: NickAger
>>>
>>> Time: 20 June 2011, 3:51:59 pm
>>>
>>> UUID: ad79427b-c248-4194-8c18-8207969a74a7
>>>
>>> Ancestors: Seaside-Session-pmm.138
>>>
>>> fix for http://code.google.com/p/seaside/issues/detail?id=659
>>>
>>> when request isPrefetch, WAApplication>>handleFiltered: DNUs with
>>> WAResponseGenerator>>doesNotUnderstand: #statusForbidden.
>>
>> Presumably this is OK? However I guess my test check-in wasn't clear as I
>> copy and pasted:
>
> Well, I'm not sure. There was a DNU.... so how did you fix it? Did you add
> the method somewhere? Change the sender to avoid sending it? Fix a bug that
> was resulting in the method being called on the wrong receiver?

Looking at the code addresses all these issues. In addition Monticello
doesn't have something like svn annotate. People will see a commit
message once and never again.

Cheers
Philippe


More information about the seaside-dev mailing list