[Seaside-dev] Set vs. IdentitySet in WAFileLibrary>>#filenames

[Julian Fitzell]

Looks ok... let's make sure to add a comment to that effect though.
Could you file an issue so there's a history and it doesn't get
dropped?

On Thu, May 26, 2011 at 10:04 AM, Paolo Bonzini <bonzini at gnu.org> wrote:
> Hi,
>
> Gwenael Casaccio recently found the following assumption in Seaside while
> working on an unrelated change to GNU Smalltalk.
>
> In WAFileLibrary>>#filenames, you are building strings from selectors:
>
>        ^self fileSelectors collect: [:each | self asFilename: each]
>
> This however is assuming that #fileSelectors (and hence
> Behavior>>#selectors) returns an Array or a Set.  Gwen would like to change
> Behavior>>#selectors return an IdentitySet.  In this case #filenames would
> return an IdentitySet of strings, which is pretty much unusable.
>
> The possible solution is to send #asArray or #asSet before #collect:. Does
> this seem okay?  Can you make the change so that when I finally upgrade to
> 3.0.x I will not see this issue?
>
> Thanks!
>
> Paolo
> _______________________________________________
> seaside-dev mailing list
> seaside-dev at lists.squeakfoundation.org
> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>