[Seaside-dev] Configurable current request context variable

[Max Leske]

Hi Philippe,

I’ve created an implementation, trying to do what you suggest; these are the changes:

- removed WADynamicVariable
- added GRDynamicVariable to Grease-Core
- subclasses of WADynamicVariable now inherit from GRDynamicVariable
- test cases for WADynamicVariable moved to Grease-Tests-Core (not sure about this. The tests should be the same for all platforms but Grease-Core does not contain GRDynamicVariable…)

I don’t have write permissions on STHub, so I’m attaching the patches below. I can also make the change for Squeak but I’m not sure how I would go about committing the change for VW / VASt. Let me know what you think.

Cheers,
Max


> On 14 May 2017, at 21:09, Philippe Marschall <philippe.marschall at gmail.com> wrote:
> 
> On Wed, May 10, 2017 at 7:16 PM, Max Leske <maxleske at gmail.com> wrote:
>> Good news: VA doesn't have dynamic variables either but their process also has an environment (called #attributes). If there's no other platform to look out for, we could simply replicate the DynamicVariable behaviour for each platform without depending on DynamicVariable. There would only be
>> 
>> GRDynamicVariable
>> ^
>> |
>> WAPharoDynamicVariable / WAVWDynamicVariable / WAVADynamicVariable
> 
> Nope. See my answer to Esteban. The idea is that the dialect specific
> implementation of Grease,
> Grease-Pharo-Core/Grease-VW-Core/Grease-VaST-Core/Grease-GemStone-Core
> would provide a class named GRDynamicVariable. The implementation
> would be either process environment based, or dynamic variable based,
> or notification based, whatever works best on this dialect. That way
> users can simply subclass GRDynamicVariable and automatically get the
> best possible behaviour on the dialect they are running on without
> having to change their code.
> 
> Cheers
> Philippe
> _______________________________________________
> seaside-dev mailing list
> seaside-dev at lists.squeakfoundation.org
> http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev