[Seaside] critical GOODS client bug fixes

[Avi Bryant]

The problem below has been fixed, and a new version (78) is up on SM.  
I strongly recommend people upgrade to this - as well as fixing the 
decoding of negative small ints (would you believe this has never 
worked properly until now, and nobody noticed? Scary...), it catches a 
couple of edge cases where, after the right combination of conflicts 
and rollbacks, some changes were getting missed during commit.

Avi

On Oct 24, 2004, at 1:24 PM, Yar Hwee Boon wrote:

> On Sun, 24 Oct 2004 13:24:03 +0200, Avi Bryant <avi at beta4.com> wrote:
>
>>
>> On Oct 24, 2004, at 6:27 AM, Yar Hwee Boon wrote:
>>
>>> I noticed a problem when storing and retrieving SmallInteger(s) in 
>>> GOODS. Run the following:
>>>
>>> =====
>>> db := KKDatabase onHost: 'localhost' port: 6100.
>>> db root at: #xx put: -3.
>>> db flushAll.
>>> (db root at: #xx) inspect
>>> ======
>>
>> You need a #commit before the #flushAll or you won't have anything at 
>> #xx at all.  But yes, having put that in I can reproduce your bug - 
>> clearly something going wrong with the signed integer representation. 
>>  I'll look into it, thanks.
>
> I thought of this, but when I try to debug and step through 
> #encodeSignedInteger: and #decodeSignedInteger: by putting #halt in 
> them, it seems not to write to the database, or write differently as 
> when I remove the #halt-s. Do you know why?.