[BUG] extraVMMemory handling is odd

Tim Rowledge rowledge at interval.com
Thu Oct 7 23:04:45 UTC 1999


The fairly recently added code to handle the extraVMMemory parameter is buggy
in the sense that it is platform-irritant. So far as  can remember, the only
platform that needs to reserve memory for the VM is the Mac, yet this code will
reduce the heapSize for all platforms regardless of whether it makes sense or
not. I don't think it likely that it would cause any big problems, but it might
be better to ensure this by adding a macro that can by default _not_ reduce the
heapSize and can be redefined in MacLand to do whatever.
For example,
#define adjustHeapSize( origHS, arg) origHS
and
#ifdef macintosh
#undef adjustHeapSize
#define adjustHeapSize( origHS, arg) origHS - arg
etc
and replace the line in Interpreter>readImageFromFile:HeapSize:StartingAt: to
read
	heapSize _ self cCode: 'adjustHeapSize( desiredHeapSize, extraVMMemory)'.

tim
-- 
Useful random insult:- Ready to check in at the HaHa Hilton.
Tim Rowledge:  rowledge at interval.com (w)  +1 (650) 842-6110 (w)
 tim at sumeru.stanford.edu (h)  <http://sumeru.stanford.edu/tim>





More information about the Squeak-dev mailing list