Yea that makes sense.  I started to write a similar addition to my original paragraph but then
figured that whomever was looking at the factoring would see this soon enough.  I did a lot of that
sort of thing to get the "skins" work going months ago.  It's where I first saw these class
references and found myself wanting to override them with my own subclasses getting used instead.

It's good to call it out like you did.

  - Steve

Stephan Rudlof wrote:

> Steve Wessels wrote:
> >
> > I have not looked at the code.  However let me not hesitate to say I think the idea of removing
> > explicit class names wherever possible and replacing them with "self class" is an excellent
> > practice.  This would be a good general refactoring project for someone to do.
>
> I have to send out a warning:
> This is difficult for Browser class methods starting a new browser (I've
> met this problem).
> I think the reason is, that e.g. HierarchyBrowser as subclass starts
> browsers over these methods (and "self" results in "HierarchyBrowser"
> instead of "Browser" then).
>
> So I think this is a valuable project, but it cannot be done by blindly
> replacing class names by "self" or "self class". Thinking, testing and
> introducing methods like e.g. Browser class>>standardBrowserClass is
> necessary to do this task.
>
> Greetings,
>
> Stephan
>
> >
> >  - Steve
> >
> >   - Steve
> >
> > mats nygren wrote:
> >
> > > Hi,
> > >
> > > read preamble, well it gzipped, here goes:
> > > While doing other things I found that the Preferences browseToolClass
> > > doesnt have much influence.
> > >
> > > I have substituted the many references to Browser as follows:
> > > - in a method in Browser or descendents: self class
> > > - in a class method in Browseror descendents: self
> > > - at (many) other places: Preferences browseToolClass
> > > - at some places (status quo): Browser
> > >
> > > Since I was working with other things there might be strange parts in
> > > some of the changes,
> > > perhaps take a look before fileIn, also for the same reason some
> > > Browser-references might remain,
> > > my apologies for the inconvienenses, I'm a ChangeSetNewbie.
> > >
> > > /Mats Nygren
> > >
> > >   ------------------------------------------------------------------------------------------
> > >                       Name: Browser.3.cs.gz
> > >    Browser.3.cs.gz    Type: unspecified type (application/octet-stream)
> > >                   Encoding: base64
>
> --
> Stephan Rudlof (sr at evolgo.de)
>    "Genius doesn't work on an assembly line basis.
>     You can't simply say, 'Today I will be brilliant.'"
>     -- Kirk, "The Ultimate Computer", stardate 4731.3