[BUG ] Weakness weakness in 3.6alpha ClassBuilder ( [cd][et] verynaive fix )

Doug Way dway at riskmetrics.com
Wed Apr 2 23:49:31 UTC 2003

I notice you replied with a fix to your bug report with the same subject line
and a comment between parentheses.

The only problem is that this keeps your fix on the SQBUGS (bug reports) page,
not the SQFIXES where it should be.  Probably you should just post a new
message (or reply) with [FIX] in the subject line instead, so that it shows up
on SQFIXES.  I guess you would lose the connection to the original bug report,
but that's okay.

See both pages:


- Doug Way

Brent Vukmer wrote:
> >From the preamble:
> >From Squeak3.6alpha of ''17 March 2003'' [latest update: #5174] on 2 April 2003 at 5:30 pm'!
> "Change Set:            ValidateSubclassFormatFix
> Date:                   2 April 2003
> Author:                 Brent Vukmer
> Following Tim Rowledge's hint, I put added a little bit of 'typeOfClass' logic to ClassBuilder>>validateSubclassFormat:from:forSuper:extra:.  Actually, I put the logic inside a new method: ClassBuilder>>validateSubclass:canKeepLayoutFrom:forSubclassFormat:.  If the subClass is 'weak' and the superclass is 'variable', then the ClassBuilder should proceed with its bidness.
> Other changes:
> --I cleaned up the formatting of validateSubclassFormat:from:forSuper:extra
> --I got rid of an extra iteration over the collection of subclasses for the 'oldClass'
> Test plan:
> --Open the browser on Array
> --Create a space inside the class definition pane, then delete the space, then hit Alt-s
>   ------------------------------------------------------------------------------
>                                            Name: ValidateSubclassFormatFix.1.cs.gz
>    ValidateSubclassFormatFix.1.cs.gz       Type: ChangeSet (application/x-unknown-content-type-cs_auto_file)
>                                        Encoding: base64
>                                     Description: ValidateSubclassFormatFix.1.cs.gz
>   ------------------------------------------------------------------------------

More information about the Squeak-dev mailing list