KCP looking for external reviewers

Daniel Vainsencher danielv at netvision.net.il
Fri Apr 4 16:50:45 UTC 2003


Cool. I want you to get reviewers, but "Kernel" sounds a little scary.
Actually many of the changes you're making are pretty simple design
issues that don't require understanding any voodoo to review, but a few
small things would help:

* I am not sure what problems you're actually attacking, from the list
of suggestions. Unless you explain every goal you decide to attack, why
should people look at your changesets? Here are the goals I know about -

 - Eliminate dependencies from the kernel class on application classes.
 - Move user level functionality (for example, that supporting
reflection (browsing senders)) out of the kernel.
Anything else? make it clear on the web page.
* Since you're changing design, it would be nice to have justifications
for the major decisions. For example, is self environment always a good
replacement for Smalltalk? external reviewers shouldn't need to reverse
engineer your changes, just review them.
* Sometime the name is so brief, I don't understand what the changeset
is supposed to do. This prevents me from finding something nice and
reviewing it.

These should make it easier for 



Stephane Ducasse <ducasse at iam.unibe.ch> wrote:
> Hi guys
> 
> We started slowly but we started. We need external reviewers for our 
> changes.
> I would like to see them included in 3.6 because there are really 
> simple until now.
> 
> http://minnow.cc.gatech.edu/squeak/3083
> 
> 
> Currently we are focusing now on having the smallest core for Class, 
> Behaviour, ClassDescription, and Metaclasses.
> 
> The first design changes introduced is the introduction of a class named
> SystemNavigation that should contain all the navigation code 
> (browseAll...). Note that all the browse methods defined in the class 
> SystemDictionary should be move into this class too to avoid duplicated 
> code and logic.
> 
> 
>   Next Major Tasks:
> 	- Look and clean the classBuilder
>   	- Look and clean the systemOrganization
>   	- Remove fileoutasHTML from the kernel
>   	- Move fileout functionality out of the kernel in another layer
>   	- Coherent and simple funnel for changes notification and access to 
> changes
>   	- Coherent and simple funnel for access to the compiler from the 
> classes (fixes classParser and classScanner as role always complained 
> about them been wrong)
> 
> 
> stef
> 
> Prof. Dr. Stéphane DUCASSE
> http://www.iam.unibe.ch/~ducasse/
>   "if you knew today was your last day on earth, what would you do 
> different? ...  especially if,
>   by doing something different, today might not be your last day on 
> earth" Calvin&Hobbes
> 
> "The best way to predict the future is to invent it..." Alan Kay.
> 
> Open Source Smalltalks: http://www.squeak.org, 
> http://www.gnu.org/software/smalltalk/smalltalk.html
> Free books for Universities at 
> http://www.esug.org/sponsoring/promotionProgram.html
> Free Online Book at 
> http://www.iam.unibe.ch/~ducasse/WebPages/FreeBooks.html



More information about the Squeak-dev mailing list