[squeak-dev] Re: [BUG] Browsers vertically squished in trunk?
casey.obrien.r at gmail.com
Wed Mar 31 00:41:29 UTC 2010
Yes, Nicolas, shenanigans were at some point sent to this method.
I did the simplest thing possible to make windows big enough to use by
default on small screens (a browser gets unusable around height 300 and
below) and decided to hold off on merciless refactoring until 4.2.
Fixed in System-cbr.306, which is in the Inbox.
On Tue, Mar 30, 2010 at 3:51 PM, Nicolas Cellier <
nicolas.cellier.aka.nice at gmail.com> wrote:
> 2010/3/31 Casey Ransberger <casey.obrien.r at gmail.com>:
> > Hmmm. Totally different behavior in this method if the preference
> > #reverseWindowStagger is enabled. What I don't understand is why the
> > staggering policy should have anything to do with the default height or
> > width of windows.
> > I am officially calling shenanigans on this method.
> Thank you for the nice idiom.
> I don't understand anything to it, but
> ^self callingShenanigans
> would certainly bring more poetry in the image than
> ^self primitiveFailed.
> > On Tue, Mar 30, 2010 at 1:56 PM, Casey Ransberger <
> casey.obrien.r at gmail.com>
> > wrote:
> >> Found it.
> >> RealEstateAgent class>>standardWindowExtent
> >> <snip>
> >> ^ (allowedArea extent - (grid*(maxLevel+1*2) + (grid//2))) min:
> >> StandardSize "600 at 400"].
> >> Something is going wrong with the math here. Changing this line to (note
> >> that I've just commented everything out and returned 600 at 400) fixes the
> >> but probably breaks tons of other stuff:
> >> ^"^ (allowedArea extent - (grid*(maxLevel+1*2) + (grid//2))) min:
> >> StandardSize "600 at 400].
> >> I'm going to see if I can figure out exactly what's going wrong with
> >> and if so, push a proper fix to the Inbox.
> >> On Tue, Mar 30, 2010 at 10:25 AM, Casey Ransberger
> >> <casey.obrien.r at gmail.com> wrote:
> >>> When I open a system browser in recent trunk images, the browser opens
> >>> squished vertically so the first thing I need to do is resize it. I
> >>> swear I'd seen this some place before, and the fix wound up being in
> >>> toolbuilder somewhere. IIRC Andreas pointed out the fix, but I can't
> >>> the message anywhere in any of my inboxes.
> >>> As a sanity check, are other people seeing this too? I might note that
> >>> I've been using Squeak on a very small screen lately, if that makes any
> >>> difference (I don't know, maybe the browser tries to open at a % of
> >>> screen real estate, which is too small on my box?)
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Squeak-dev