[squeak-dev] Daily Commit Log
commits at source.squeak.org
commits at source.squeak.org
Wed Feb 22 23:55:07 UTC 2012
Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours:
http://lists.squeakfoundation.org/pipermail/packages/2012-February/005198.html
Name: Morphic-nice.611
Ancestors: Morphic-cmm.610
Avoid the compiler notification offset to be doubled when evaluating a sub-selection in a TextEditor.
Notes:
In Squeak, the notification offset is already taken into account in the source Stream because of
TextEditor>>selectionAsStream
"Answer a ReadStream on the text in the paragraph that is currently selected."
^ReadWriteStream
on: paragraph string
from: self startIndex
to: self stopIndex - 1
So it is not necessary to add the self startIndex offset one more time in TextEditor>>notify:at:in:
This might differ from Cuis solution.
=============================================
http://lists.squeakfoundation.org/pipermail/packages/2012-February/005199.html
Name: Compiler-nice.225
Ancestors: Compiler-nice.224
Remove the ugly hack in Parser>>expected: which was modifying the error message insertion mark depending on the fact that we were at end of token stream a,d/or end of source character stream.
Replace it with a proper mark in Scanner>>scanToken that correctly take into account the two step of advance handled by the Scanner (stateful is harmful and require high precision surgery).
While at it, set the error insertion mark after the $ character when offended by Scanner>>xDollar.
This efficiently reduce the number of failures reported by CompilerNotifyngTest in its Tests-nice.144 version.
=============================================
http://lists.squeakfoundation.org/pipermail/packages/2012-February/005200.html
Name: Tests-nice.144
Ancestors: Tests-nice.143
Add some tests for Compiler notifications
- do we get the right notification ?
- inserted at the right place in text ?
This is an unfinished work with expected failures.
But absolutely necessary to solve issues like http://code.google.com/p/pharo/issues/detail?id=3439
=============================================
http://lists.squeakfoundation.org/pipermail/packages/2012-February/005201.html
Name: Tests-nice.145
Ancestors: Tests-nice.144
1) Register the 4 CompilerNotifyingTest that insert Compiler notifications at wong place as expectedFailures because this is kind of wishful testing.
Indeed, these notifications are not emitted immediately during parsing/scanning phase but rather during transformation of the AST (inlining) or during encoding phase, when positional infomation might exist, but not in a handy form.
2) Remove CompilerNotifyingTest>>testTooManyTemporaries because the Closure Compiler raise other Errors before notification get a chance to occur.
3) Correct CompilerNotifyingTest>>testAlltogether whose specification was missing a sub-selection separator.
The CompilerNotifyingTest are now green.
=============================================
http://lists.squeakfoundation.org/pipermail/packages/2012-February/005202.html
Name: Tests-nice.146
Ancestors: Tests-nice.145
Add a variant CompilerSyntaxErrorNotifyingTest for testing case of so called non interactive Compiler notification.
See class comment for the funny definition of "non interactive".
=============================================
More information about the Squeak-dev
mailing list
|