[squeak-dev] The Inbox: System-fbs.586.mcz

Bert Freudenberg bert at freudenbergs.de
Mon Aug 12 15:42:14 UTC 2013


On 2013-08-12, at 14:53, commits at source.squeak.org wrote:

>  checkForUpdates
>  	| availableUpdate updateServer |
>  	World 
>  		ifNotNil: [
>  			World install.
>  			ActiveHand position: 100 at 100].
> - 	HTTPClient isRunningInBrowser
> - 		ifFalse: [^self processUpdates].
>  	availableUpdate := (AbstractLauncher extractParameters
>  		at: 'UPDATE'
>  		ifAbsent: [''] ) asInteger.
>  	availableUpdate
>  		ifNil: [^false].
>  	updateServer := AbstractLauncher extractParameters
>  		at: 'UPDATESERVER'
>  		ifAbsent: [AbstractLauncher extractParameters
>  		at: 'UPDATE_SERVER'
>  		ifAbsent: ['Squeakland']].
>  	Utilities setUpdateServer: updateServer.
>  	^SystemVersion checkAndApplyUpdates: availableUpdate!


This change would always execute the case meant for the web-browser plugin. (this whole mechanism is unused anyway, even in Etoys, but still)

Also, what's wrong with "Utilities updateFromServer"? Seems to me much nicer and easier to remember than "MCMcmUpdater updateFromServer". Call it a Facade, if you need to appease the gods of agile ;)

- Bert -




More information about the Squeak-dev mailing list