[squeak-dev] name in various FooTheme class>>#createFoo methods

Eliot Miranda eliot.miranda at gmail.com
Fri Oct 14 18:13:52 UTC 2016

Hi Marcel,

    I see the "name is shadowed" warning from methods such as

CommunityTheme class>>#createDark
"self createDark apply."
| name |
name := 'Community (dark)'.
^ (self named: name) in: [:theme |
theme merge: (self named: 'Squeak') overwrite: true.
theme name: name.
"General morph stuff."

and I thought to correct them but then thought that they don't need the
name ten var at all, and hence realised they could be auto generated.  Are
they?  Is it safe to edit them to rename name to e.g. themeName, or even to
eliminate the temp var altogether?

best, Eliot
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20161014/639ccfa2/attachment.htm

More information about the Squeak-dev mailing list