[squeak-dev] name in various FooTheme class>>#createFoo methods

Levente Uzonyi leves at caesar.elte.hu
Sat Oct 15 09:37:23 UTC 2016

On Fri, 14 Oct 2016, Eliot Miranda wrote:

> Hi Marcel,
>     I see the "name is shadowed" warning from methods such as 
> CommunityTheme class>>#createDark
> "self createDark apply."
> | name |
> name := 'Community (dark)'.
> ^ (self named: name) in: [:theme |
> theme merge: (self named: 'Squeak') overwrite: true.
> theme name: name.
> "General morph stuff."
> theme
> ...
> and I thought to correct them but then thought that they don't need the name ten var at all, and hence realised they could be auto generated.  Are
> they?  Is it safe to edit them to rename name to e.g. themeName, or even to eliminate the temp var altogether?

Totally irrelevant, but what's the point of using #in: when a temporary 
variable would do it?


> _,,,^..^,,,_
> best, Eliot

More information about the Squeak-dev mailing list