[squeak-dev] The Trunk: Kernel-pre.1105.mcz
Patrick.Rein at hpi.de
Fri May 19 13:16:09 UTC 2017
Regarding the headerFlagForEncoder: method: I only wanted to make the
code easier to understand. I have no experience with the CompiledCode
and Encoder classes and did not want to break anything there.
Regarding the two commits: I should have ignored the change... I have now
moved the commit in the Inbox to the Treated Inbox. The change is still
open for discussion though :)?
From: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> on behalf of Nicolas Cellier <nicolas.cellier.aka.nice at gmail.com>
Sent: Friday, May 19, 2017 14:32
To: The general-purpose Squeak developers list
Subject: Re: [squeak-dev] The Trunk: Kernel-pre.1105.mcz
2017-05-19 14:22 GMT+02:00 <commits at source.squeak.org<mailto:commits at source.squeak.org>>:
Patrick Rein uploaded a new version of Kernel to project The Trunk:
==================== Summary ====================
Time: 19 May 2017, 2:22:29.00196 pm
Removes a redundancy in CompiledCode.
=============== Diff against Kernel-nice.1103 ===============
Item was changed:
----- Method: CompiledCode class>>headerFlagForEncoder: (in category 'method encoding') -----
- anEncoder class == PrimaryBytecodeSetEncoderClass ifTrue:
- anEncoder class == SecondaryBytecodeSetEncoderClass ifTrue:
- [^SmallInteger minVal].
"This allows subclasses for compiler variants such as the ScriptEncoder in EToys
to continue to function."
+ (anEncoder isKindOf: PrimaryBytecodeSetEncoderClass) ifTrue:
- (anEncoder class inheritsFrom: PrimaryBytecodeSetEncoderClass) ifTrue:
+ (anEncoder isKindOf: SecondaryBytecodeSetEncoderClass) ifTrue:
- (anEncoder class inheritsFrom: SecondaryBytecodeSetEncoderClass) ifTrue:
self error: 'The encoder is not one of the two installed bytecode sets'!
Then why not send a message back to anEncoder?
Way more efficient than testing classes sequentially and recursively...
Item was added:
+ ----- Method: Number>>** (in category 'mathematical functions') -----
+ ** aNumber
+ ^ self raisedTo: aNumber!
Above change can't both be waiting in inbox and be commited to trunk
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Squeak-dev