Hi Marcel,


sounds great! Did you already have a look at Morphic-ct.1554? As it happens, I worked on #debugAction for the debug menu myself today and eliminated some duplication. Maybe you could merge these changes? :-)


Also, maybe we should consider combining #doButtonAction and #performAction? It would be great to have the debugAction for every morph ... Could we just override #doButtonAction in PluggableButtonMorph and offer the debugAction without any condition?


Best,

Christoph

________________________________
Von: Squeak-dev <squeak-dev-bounces at lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel
Gesendet: Dienstag, 1. Oktober 2019 18:33:54
An: Alan Grimes via Squeak-dev
Betreff: [squeak-dev] Please Review | Further Debugger Improvements

Hi, all.

Please find attached a change set to further improve our debugger infrastructure.

- Replaces ErrorRecursion and ErrorRecursionGard with a process-local variable DebuggerErrorRecursionFlag.
- !!! Adds several tests in DebuggerTests.
- Simplifies Project >> #interruptName:preemptedProcess:
- Simplifies "Debug it" invocation. See Process class >> #forBlock:at: and senders of it such as TextEditor >> #debugIt.
- Adds PluggableTextMorph >> #debugAction and MenuItemMorph >> #debugAction. See those morph's debug menus via halo.
- Move log-file writing for low space to SmalltalkImage >> #lowSpaceWatcher.
- Adds Debugger >> #close, similar to Project >> #close.

There are still some quirks with MVC debugging but Morphic should be fine.

Best,
Marcel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20191001/d365b26c/attachment.html>