After all the recent fun of getting a version of squeaksource running locally, fixing some bugs and slightly improving the security, I noticed that on the swiki pages the headings were just plain wrong. This problem is easily observable on the main squeaksource.com site too.

The parsing rules say that 
!heading
should produce an html 
<h1>heading</h1> 
tag - but in fact we were getting some weird junk looking like
<heading></heading><level>1</level><with>heading</with>.
Which doesn't seem quite right. It renders as 
1heading
- definitely not what we wanted.

I tracked it down to a fairly silly and very old bug in TWViewer>visitHeading: that took a bit of head-scratching to solve, for reasons largely to do with the fact that there are NO DAMN COMMENTS anywhere. Whoever wrote that - please accept this virtual nose-poke.

I found two other places where the same problem was occurring due to a different aspect of the same bug, but I can't see what on Earth the html is actually doing. For example, in TWWiki>renderWikiReferencesOn: the produced html is basically that shown above plus one or more internal wiki links. What we actually see on the page is 
References: Home otherLink
where, a bit oddly, the References gets a colon added and bolded. There is one possibly significant difference in the html though, in that the <level> tags are actually <level1>. But I am no expert in current html and quick googling doesn't provide any immediately inspiring answers.

If I change the references listing to a more sensible looking (to me) use of #heading: and #list:do: then we get the list of references but in a vertical list instead of a horizontal row, and weirdly the heading is simply not displayed. It *is* in the html though. Gronk?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: TinySwikiHeadings.1.cs
Type: application/octet-stream
Size: 1529 bytes
Desc: not available
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20190923/f86a03e7/attachment.obj>
-------------- next part --------------


tim
--
tim Rowledge; tim at rowledge.org; http://www.rowledge.org/tim
All new: The software is not compatible with previous versions.