> On 2021-12-30, at 12:00 AM, Bernhard Pieber <bernhard at pieber.com> wrote:
> 
> Hi Tim,
> 
> Funny, I recently stumbled over this as well. It would be great if things could be improved in that area. As for the file extension: I would suggest using .ws.st.

Sounds sensible to me.

What I've done so far is 
 - clean up the Workspace creation when editing a file; this had the advantage of making it work in MVC properly
 - make the 'workspace with contents' use that, though I still ought to changed the Service to clean it up
 - make the 'edit' button use the Workspace too; I think that should replace the 'workspace with contents'
 - make the FileList class>>#openFileDirectly use it. 
 - make FileStream class>>#edit: & FileStream>>#edit use it

That stuff is all pretty simple clean-up that *could* go into the release if Marcel agrees; he's the ReleaseManager and his word is The Law for now.

Attached is a copy to try out if you're interested 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: TPR-Workspace-improvement.2.cs
Type: application/octet-stream
Size: 3147 bytes
Desc: not available
URL: <http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20211230/7204e0d4/attachment-0001.obj>
-------------- next part --------------


Some questions about how it should work, almost certainly for later - 

 - should a Workspace being used to edit a file have a way to (re)load the file contents if the file is altered elsewhere? We of course have the cancel facility, but should that work by reloading a connected file? A separate option?

- should there be a not-a-code-related text editor equivalent? Sure, you can use a Workspace but maybe it would be better, especially as a not-developer-tool, to have a text editor/file editor as well

 - take a look at the StringHolder hierarchy. OK, a Workspace is quite reasonably a subclass. But all those others? Nah. That's just bad design.

tim
--
tim Rowledge; tim at rowledge.org; http://www.rowledge.org/tim
Strange OpCodes: BOZO: Use Multics operating system