[FIX] isKindOfbyIsClass-asm ( [cd][er][su][et][sl] Recommend including the modified cs )

[tomkoenig at mindspring.com]

Alejandro's original changeset modified 55 classes and 74 methods, if I
counted correctly. 10 months later only about 24 of the changes still
apply.  They are included in the change set.
I deleted changes to CRDictionary, CRDictionaryBrowser,
PluggableCollectionMorph, PluginHTTPRequest since these are no longer in
the image and naturally I could not load the cs until they were removed.
I inspected all of the methods in the cs.  A large number were deleted
from the change set because the changes had already been made
(especially by Ned, e.g. 6097 isStringFixes-nk).  In a number of cases,
subsequent changes had been implemented so I regressed to the prior
verions, and reapplied Alexandro changes.

I then found/created, executed and verified manual tests for all but one
of the remaining methods, with 3.9a#6520. All but two tests that  passed
successfully.  I  backed out one change that should have worked but did
not and reported the bug separately.  I was not able to create a test
for   ImageSegment, so that change  in a separate cs.     
I recommend that we include the (modified) isKindOfbyIsClass-asm
changeset in 3.9a but not the isKindOfForImageSegment cs until we can
come up with a convincing test for ImageSement
Tom
The list of tests conducted follows
Behavior >> literalScannedAs:notifying:  tested using examples in method
plus sunit test
Form literalScannedAs: 14 notifying: nil  
Form literalScannedAs: #OneBitForm notifying: nil   
Form literalScannedAs: ##OneBitForm notifying: nil           
Form literalScannedAs: ##Form notifying: nil                   
Form literalScannedAs: ###Form notifying: nil  
BitBlt >> paintBit pixelAt:put:  
BitBlt benchmark3  [ showed no difference to speak of]    used examples
Browser >>  defineClass:notifying:  	BrowseTest
Class tested using DeepCopier new checkVariables a DeepCopier.
ClassBuilder ClassBuilderTest
ClassDescription ClassDescriptionTest
GenericPropertiesMorph tested using TextPropertiesMorph initialize 
(InfiniteForm with: (Form extent: 40 at 40)) displayOn: Display at: 10 at 10 
  clippingBox: (Rectangle center: 5 at 5 extent:  15 at 15) rule: 1 fillColor:
Color red.
(Inspector inspect: 1) copyName
(Inspector inspect: #('a' 'b')) copyName
PackageInfo new externalCallers
(ParagraphEditor newParagraph: (Paragraph withText: (Text fromString:
'abcdefg'))) explain
PhraseTileMorph new vocabulary: Vocabulary new 
PhraseTileMorph new vocabulary: #S
Player new slotInfoAt: '5'
(PluggableListView on: (#('1' '2' '3') asOrderedCollection) 
  list: #contents selected: #first changeSelected: #at:put:)
verifyContents
PostscriptCanvas new stroke: Color red [this fails but not before
successfully testing changed code]
 PseudoClass new name: 'Object'; exists
PseudoClass new name: 'Display'; exists
(Scanner new scan: (ReadStream on: '#at  1')) nextLiteral
(Scanner new scan: (ReadStream on: '#at  1')) nextLiteral; nextLiteral
SequenceableCollection (plus sunit tests)
#('a' b ) asStringWithCr
#('a' b ) copyReplaceAll: 'a' with: 'x' asTokens: false
'a b'   copyReplaceAll: 'a' with: 'x' asTokens: false
SystemNavigation default browseObsoleteReferences 
(TextURL scanFrom:'www.altavista.digital.com/') actOnClickFor: BlobMorph
new
TheWorldMenu new appearanceMenu
TileMorph new rawVocabulary: Vocabulary new
(UpdatingStringMorph on: #(s ) selector: #first) readFromTarget
-------------- next part --------------
A non-text attachment was scrubbed...
Name: isKindOfForImageSegment.cs.gz
Type: application/octet-stream
Size: 2424 bytes
Desc: not available
Url : http://lists.squeakfoundation.org/pipermail/squeak-harvest/attachments/20041205/8c1924c6/isKindOfForImageSegment.cs.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: isKindOfbyIsClass-asm.cs.gz
Type: application/octet-stream
Size: 5764 bytes
Desc: not available
Url : http://lists.squeakfoundation.org/pipermail/squeak-harvest/attachments/20041205/8c1924c6/isKindOfbyIsClass-asm.cs.obj