[V3dot9] Re: again garbled changeset....

[stéphane ducasse]

This is strange. Because we tried from a fresh 3.9 7056 and we got  
unnamed.


This code is a bit terrible.

On 11 sept. 06, at 10:16, Marcus Denker wrote:

> Hi,
>
> The changeset bug seems to be hard to kill... it's again there in  
> 7057. I think the problem is
> this:
>
> resetCurrentToNewUnnamedChangeSet
> 	current := self new.
> 	self newChanges: current
>
>
> problem: "new" is implemented as:
>
> new
> 	"All current changeSets must be registered in the AllChangeSets  
> collection.
> 	Due to a quirk of history, this is maintained as class variable of  
> ChangeSorter."
>
> 	^ self basicNewChangeSet: ChangeSet defaultName
>
>
> "Changeset defaultName" now returns 'Unamed1', not 'Unamed', as it  
> wants to
> make a new name:
>
> defaultName
> 	^ self uniqueNameLike: 'Unnamed' translated
>
> Which means, we need to change the code to be
>
> resetCurrentToNewUnnamedChangeSet
> 	current := self basicNewNamed: 'Unamed'.
> 	self newChanges: current

Did you try?

Stef

>
> I hope. All this changeset and filout related code is horrible and  
> should be thrown away.
>
>      Marcus
>