[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Add stack win32 build (#317)

[Nicolas Cellier]

nicolas-cellier-aka-nice commented on this pull request.



> @@ -0,0 +1,38 @@
+#############################################################################
+# Makefile for Win32 Stack Spur PharoVM using gcc and cygwin
+# Do make init to allow make -n to function.
+#############################################################################
+
+VM:=Pharo
+VM_NAME:=Pharo Virtual Machine
+
+VMSRCDIR:=../../spurstacksrc/vm
+# NOTES: 
+# STACK_ALIGN_BYTES=16 is needed in mingw and FFI (and I suppose on other modules too).
+# ALLOCA_LIES_SO_USE_GETSP=0 Some compilers return the stack address+4 on alloca function, 
+# then FFI module needs to adjust that. It is NOT the case of mingw.
+# For more information see this thread: http://forum.world.st/There-are-something-fishy-with-FFI-plugin-td4584226.html
+#COGDEFS:= -DPharoVM=1 -DSTACK_ALIGN_BYTES=16 -DALLOCA_LIES_SO_USE_GETSP=0

These comments are troubling...
Either these flags are necessary as the comment tells... but then why don't we find them in code?
... or they are not anymore to date and should be removed.
I know you did not add these lines by yourself, only copied them, but someone forgot to clean up, so while at it...
(All these changes are marked as authored by Esteban, but I'm pretty sure that it was me who did perform the cleanup; at the time when wanting to work in a parallel pharo repository, git was somehow missused!) 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/317#pullrequestreview-183433414
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20181210/736620c7/attachment.html>