[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] FileAttributesPlugin: Add session Id (f6445ab)

[Ben Coman]

On Mon, 17 Dec 2018 at 15:10, akgrant43 <notifications at github.com> wrote:

> Hi Eliot,
>
> This is an internal commit of the plugin I did during development, the
> latest version from the merge is:
>
> 94c54ed#diff-04cbc775a3686446b844a93e1520e706
> <https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/94c54edc5bbb8dfac318686176e67ceaa20883bb#diff-04cbc775a3686446b844a93e1520e706>
>
> The repository is configured to not allow squash merges, so all the
> commits that are part of a PR will always be present.
>
To provide cleaner PRs, I tend to "git commit --amend" to my-branch that I
issued a PR from and force push that to my github account.
In spite of the general advice not to force push public branches, in
reality it seems people rarely branch except from the canonical account.
Actually this could be covered by a convention like...
    "if you branch from someone's personal account, immediately push it to
your account so it shows up in the network view."
Forcing pushing only a problem if someone has branched from it the network
view could be checked before forcing pushing.

cheers -ben

>


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f6445ab9ea75f685e4e53bff8917449646c3754b#commitcomment-31702943
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20181217/3675675a/attachment.html>