[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] sqUnixXdnd: Don't record SQDragLeave when XdndDrop is handled (#508)

[David Stes]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256


Hi,

I'm just commenting on this out of interest, I cannot say anything on
whether this PR is going to be merged, as I have nothing to do with that.

As far as I can see this looks a reasonable change, but we don't know,
how the original author(s) think about it, whether they had a reason for 
their implementation.

But the context of your work is a little bit clearer now to me.

Basically you have dropFiles-examples.13.cs  dropFiles3.14.cs changesets.

In my image I can "fileIn" those changesets by Tools->FileList and then
clicking "fileIn".

My understanding is now that you need some VM changes/support for the
dropFiles3.14.cs changeset, i.e. the underlying VM has some behavior,
that you want to change for the dropFiles changes.

If it's useful I can do further testing on this X11 platform,
as from what I understand this change is relevant to the Solaris X11 support.

For the moment - this may be a Solaris specific problem - when I test,
drag and drop after fileIn of the dropFiles changeset I get the following,
in a debugger:

- --- The full stack ---
FileDirectory class>>requestDropDirectory:
[] in HandMorph>>collectDropFilesAndDirectories:
Interval>>collect:
HandMorph>>collectDropFilesAndDirectories:
HandMorph>>generateDropFilesEvent:
HandMorph>>processEvents
[] in WorldState>>doOneCycleNowFor:
Array(SequenceableCollection)>>do:
WorldState>>handsDo:
WorldState>>doOneCycleNowFor:
WorldState>>doOneCycleFor:
PasteUpMorph>>doOneCycle
[] in MorphicProject>>spawnNewProcess
[] in FullBlockClosure(BlockClosure)>>newProcess

There may be Solaris specific issues with the FileDirectory I don't know.

David Stes

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJfPkVcAAoJEAwpOKXMq1MaPcAH/R0nTxahFVzPv6abeDbA9gMh
GTKEXZBpQ/dEXCLedu1IVtUFnqqK2wdJJRt2HmhRZD3sxoT3YqnZfyJkip5A9mFt
+npBuMRsCAAu2suvmOpUMJQK6HTb9/hAJiAgNEDSnQ9RUFutIBo0+6MEONGj8vGF
WuJm31p9b8cAqLhi5twA3CcKC2P8PNkF+QS8RHDSO2SMJpEuGaTgxbCYkXJPEp15
o1cdZPqKcIlJGsf23B4V2XBWI38YxVOcMUS5CYzyACi8s/NnrCS5hNeAqzLX27QH
dLhTZipSvQlcwkS7sz1X1Xm5soVmNbVwZIhkUK4ydmWGiElgbl0ZkQgJtijgY7k=
=BNaM
-----END PGP SIGNATURE-----


-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/508#issuecomment-677495161
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20200820/c0b9c570/attachment-0001.html>