[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] 83e48c: There appears to be a Windows bug (in at least Win...

Eliot Miranda noreply at github.com
Sat Oct 22 19:29:36 UTC 2022


  Branch: refs/heads/virtend
  Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
  Commit: 83e48c28aecd20f0c6368a82b00ed7cfaae384e8
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/83e48c28aecd20f0c6368a82b00ed7cfaae384e8
  Author: Eliot Miranda <eliot.miranda at gmail.com>
  Date:   2022-10-22 (Sat, 22 Oct 2022)

  Changed paths:
    M platforms/win32/plugins/DropPlugin/sqWin32Drop.c
    M platforms/win32/plugins/FileDialogPlugin/sqWin32FileDialog.c

  Log Message:
  -----------
  There appears to be a Windows bug (in at least Windows 10) such that
if a file is dropped from an Open File Dialog opened by the FileDialogPlugin
then the GlobalFree (in DropTarget_Drop in sqWin32Drop.c) of the data handle
for the dropped files will corrupt the Windows heap.  Add a flag, cleared
momentarily by the dialog functions in sqWin32FileDialog.c, to avoid freeing
in this case.


  Commit: 2431b7d7cb72f281f468679643351e9eb3b90c08
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/2431b7d7cb72f281f468679643351e9eb3b90c08
  Author: Eliot Miranda <eliot.miranda at gmail.com>
  Date:   2022-10-22 (Sat, 22 Oct 2022)

  Changed paths:
    M platforms/win32/plugins/DropPlugin/sqWin32Drop.c

  Log Message:
  -----------
  Reformat "if(" et al in sqWin32Drop.c to "if ("; if et al are not functions.


Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/12193f9687b4...2431b7d7cb72


More information about the Vm-dev mailing list