[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] 404e4d: There appears to be a Windows bug (in at least Win...
Eliot Miranda
noreply at github.com
Sat Oct 22 19:32:05 UTC 2022
Branch: refs/heads/Cog
Home: https://github.com/OpenSmalltalk/opensmalltalk-vm
Commit: 404e4dae74608b1d071c2f97da985723e2b95b0e
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/404e4dae74608b1d071c2f97da985723e2b95b0e
Author: Eliot Miranda <eliot.miranda at gmail.com>
Date: 2022-10-22 (Sat, 22 Oct 2022)
Changed paths:
M platforms/win32/plugins/DropPlugin/sqWin32Drop.c
M platforms/win32/plugins/FileDialogPlugin/sqWin32FileDialog.c
Log Message:
-----------
There appears to be a Windows bug (in at least Windows 10) such that
if a file is dropped from an Open File Dialog opened by the FileDialogPlugin
then the GlobalFree (in DropTarget_Drop in sqWin32Drop.c) of the data handle
for the dropped files will corrupt the Windows heap. Add a flag, cleared
momentarily by the dialog functions in sqWin32FileDialog.c, to avoid freeing
in this case.
Commit: d38512e25d3274fa10c880a45f2e4dd31b526163
https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/d38512e25d3274fa10c880a45f2e4dd31b526163
Author: Eliot Miranda <eliot.miranda at gmail.com>
Date: 2022-10-22 (Sat, 22 Oct 2022)
Changed paths:
M platforms/win32/plugins/DropPlugin/sqWin32Drop.c
Log Message:
-----------
Reformat "if(" et al in sqWin32Drop.c to "if ("; if et al are not functions.
Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/fe288b3b9989...d38512e25d32
More information about the Vm-dev
mailing list