Marcel Taeumel uploaded a new version of MonticelloConfigurations to project The Trunk:
http://source.squeak.org/trunk/MonticelloConfigurations-mt.166.mcz
==================== Summary ====================
Name: MonticelloConfigurations-mt.166
Author: mt
Time: 6 July 2021, 2:41:28.982497 pm
UUID: 4fcddd57-a563-4394-a3be-89ce77c26d17
Ancestors: MonticelloConfigurations-mt.165
In the update dialog, show the timestamp of the CI badge to better assess the relevance of the badge (i.e. passed, failed, error).
Note that we would have needed this information to notice that our CI builds were disabled from June 6 to July 5. :-)
=============== Diff against MonticelloConfigurations-mt.165 ===============
Item was changed:
----- Method: MCMcmUpdater>>updateMessageFor: (in category 'private') -----
updateMessageFor: previousUpdateLevel
+ ^ ('Update completed.<br><br>Version: {1}<br>Update: {3}<b>{2}</b><br><br>Url: <a href="{4}">{4}</a><br>Map: ''{5}''<br>TravisCI status: <a href="{8}"><img src="{7}" /> {9}</a>{6}' translated format: {
- ^ ('Update completed.<br><br>Version: {1}<br>Update: {3}<b>{2}</b><br><br>Url: <a href="{4}">{4}</a><br>Map: ''{5}''<br>TravisCI status: <a href="{8}"><img src="{7}" /></a>{6}' translated format: {
SystemVersion current version.
SystemVersion current highestUpdate.
previousUpdateLevel = SystemVersion current highestUpdate
ifTrue: ['']
ifFalse: [previousUpdateLevel asString, ' -> '].
self repository.
MCMcmUpdater updateMapName.
SystemVersion current description ifEmpty: [''] ifNotEmpty: [:d |
'<br><br>', (d copyReplaceAll: String cr with: '<br>')].
SystemVersion current ciStatusBadgeUrl.
SystemVersion current ciStatusPageUrl.
+ SystemVersion current ciStatusTimestamp.
}) asTextFromHtml!
Marcel Taeumel uploaded a new version of Collections to project The Trunk:
http://source.squeak.org/trunk/Collections-mt.952.mcz
==================== Summary ====================
Name: Collections-mt.952
Author: mt
Time: 5 July 2021, 11:33:42.546805 am
UUID: f848913c-5ee8-e349-8b6d-3646fb60c7b0
Ancestors: Collections-ct.951
Now that the simple/faster version of #take: was pushed down to ReadStream, do the same for ReadWriteStream.
Note that we still have to figure out whether we can set the readLimit from the beginning in those ReadWriteStreams.
Also see:
http://lists.squeakfoundation.org/pipermail/squeak-dev/2021-June/215910.htmlhttp://lists.squeakfoundation.org/pipermail/squeak-dev/2021-July/215958.html
=============== Diff against Collections-ct.951 ===============
Item was added:
+ ----- Method: ReadWriteStream>>take: (in category 'collections - accessing') -----
+ take: maxNumberOfElements
+ "Overridden for efficiency."
+
+ ^ self next: maxNumberOfElements!
Marcel Taeumel uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-ct.1632.mcz
==================== Summary ====================
Name: Morphic-ct.1632
Author: ct
Time: 29 February 2020, 11:29:22.475896 am
UUID: 2d941b38-6604-cb43-bfbb-b7751aa2d55c
Ancestors: Morphic-mt.1631
Proposal: In Morph>>#balloonText, also try to invoke balloonSelector on model.
=============== Diff against Morphic-mt.1631 ===============
Item was changed:
----- Method: Morph>>balloonText (in category 'accessing') -----
balloonText
+ "Answer balloon help text or nil, if no help is available."
+ "NB: subclasses may override such that they programatically construct the text, for economy's sake, such as model phrases in a Viewer."
- "Answer balloon help text or nil, if no help is available.
- NB: subclasses may override such that they programatically
- construct the text, for economy's sake, such as model phrases in
- a Viewer"
+ | balloonSelector |
+ extension ifNil: [^ nil].
- | result |
- extension ifNil: [^nil].
extension balloonText
+ ifNotNil: [:balloonText | ^ balloonText].
+ balloonSelector := extension balloonTextSelector
+ ifNil: [^ nil].
+ (ScriptingSystem helpStringOrNilFor: balloonSelector)
+ ifNotNil: [:result | ^ result].
+ balloonSelector == #methodComment
+ ifTrue: [^ self methodCommentAsBalloonHelp].
+ balloonSelector isUnary
+ ifTrue: [
+ (self respondsTo: balloonSelector)
+ ifTrue: [^ self perform: balloonSelector].
+ (self model respondsTo: balloonSelector)
+ ifTrue: [^ self model perform: balloonSelector]].
+ ^ nil!
- ifNotNil: [:balloonText | result := balloonText]
- ifNil: [extension balloonTextSelector
- ifNotNil: [:balloonSelector |
- result := ScriptingSystem helpStringOrNilFor: balloonSelector.
- (result isNil and: [balloonSelector == #methodComment])
- ifTrue: [result := self methodCommentAsBalloonHelp].
- ((result isNil and: [balloonSelector numArgs = 0])
- and: [self respondsTo: balloonSelector])
- ifTrue: [result := self perform: balloonSelector]]].
- ^ result!
Marcel Taeumel uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-mt.1776.mcz
==================== Summary ====================
Name: Morphic-mt.1776
Author: mt
Time: 5 July 2021, 11:27:15.873805 am
UUID: bd3f9f78-4d29-9c42-924f-b62ea426fa90
Ancestors: Morphic-mt.1775, Morphic-ct.1632
Merges Morphic-ct.1632.
In Morph>>#balloonText, also try to invoke balloonSelector on model.
=============== Diff against Morphic-mt.1775 ===============
Item was changed:
----- Method: Morph>>balloonText (in category 'accessing') -----
balloonText
+ "Answer balloon help text or nil, if no help is available."
+ "NB: subclasses may override such that they programatically construct the text, for economy's sake, such as model phrases in a Viewer."
- "Answer balloon help text or nil, if no help is available.
- NB: subclasses may override such that they programatically
- construct the text, for economy's sake, such as model phrases in
- a Viewer"
+ | balloonSelector |
+ extension ifNil: [^ nil].
- | result |
- extension ifNil: [^nil].
extension balloonText
+ ifNotNil: [:balloonText | ^ balloonText].
+ balloonSelector := extension balloonTextSelector
+ ifNil: [^ nil].
+ (ScriptingSystem helpStringOrNilFor: balloonSelector)
+ ifNotNil: [:result | ^ result].
+ balloonSelector == #methodComment
+ ifTrue: [^ self methodCommentAsBalloonHelp].
+ balloonSelector isUnary
+ ifTrue: [
+ (self respondsTo: balloonSelector)
+ ifTrue: [^ self perform: balloonSelector].
+ (self model respondsTo: balloonSelector)
+ ifTrue: [^ self model perform: balloonSelector]].
+ ^ nil!
- ifNotNil: [:balloonText | result := balloonText]
- ifNil: [extension balloonTextSelector
- ifNotNil: [:balloonSelector |
- result := ScriptingSystem helpStringOrNilFor: balloonSelector.
- (result isNil and: [balloonSelector == #methodComment])
- ifTrue: [result := self methodCommentAsBalloonHelp].
- ((result isNil and: [balloonSelector numArgs = 0])
- and: [self respondsTo: balloonSelector])
- ifTrue: [result := self perform: balloonSelector]]].
- ^ result!
Marcel Taeumel uploaded a new version of Morphic to project The Trunk:
http://source.squeak.org/trunk/Morphic-ct.1659.mcz
==================== Summary ====================
Name: Morphic-ct.1659
Author: ct
Time: 16 May 2020, 8:48:50.198708 pm
UUID: 49bbe6f6-5242-1b41-9823-d21b50d6b438
Ancestors: Morphic-nice.1658
Proposal: Have windows' menu box act on mouseDown rather than on mouseUp like the other boxes. This saves you another click and is more consistent to the usual menu flow in Squeak.
=============== Diff against Morphic-nice.1658 ===============
Item was changed:
----- Method: SystemWindow>>createMenuBox (in category 'initialization') -----
createMenuBox
^ (self createBox: self class menuBoxImage)
actionSelector: #offerWindowMenu;
+ setBalloonText: 'window menu' translated;
+ actWhen: #buttonDown;
+ yourself!
- setBalloonText: 'window menu' translated!
Marcel Taeumel uploaded a new version of CollectionsTests to project The Trunk:
http://source.squeak.org/trunk/CollectionsTests-ct.361.mcz
==================== Summary ====================
Name: CollectionsTests-ct.361
Author: ct
Time: 30 June 2021, 1:06:31.83741 am
UUID: b30fd619-d876-9f46-bfcf-d233d25b17ed
Ancestors: CollectionsTests-nice.354
Tests Generator(Stream) >> #take: which currently returns superfluous nil values if the generator does not have enough elements. Will be fixed with Collections-ct.950!
=============== Diff against CollectionsTests-nice.354 ===============
Item was added:
+ ----- Method: GeneratorTest>>testTake (in category 'tests') -----
+ testTake
+
+ | generator |
+ generator := self numbersBetween: 1 and: 3.
+ self assert: #(1 2) equals: (generator take: 2) asArray.
+ self assert: #(3) equals: (generator take: 2) asArray!
Marcel Taeumel uploaded a new version of Collections to project The Trunk:
http://source.squeak.org/trunk/Collections-ct.951.mcz
==================== Summary ====================
Name: Collections-ct.951
Author: ct
Time: 30 June 2021, 11:28:40.378415 pm
UUID: 20041ac2-26ea-5547-a7df-b98ad4b192d6
Ancestors: Collections-mt.945
Fixes Stream >> #take:. Unlike in #any:, we must not return nil values from #next here but the enumeration earlier. However, we can keep the fast behavior for ReadStreams in which #next: automatically stops the enumeration at the end of the receiver. See CollectionsTests-ct.361.
Supersedes Collections-ct.950. Thanks to Marcel for the fast review!
=============== Diff against Collections-mt.945 ===============
Item was added:
+ ----- Method: ReadStream>>take: (in category 'collections - accessing') -----
+ take: maxNumberOfElements
+ "Overridden for efficiency."
+
+ ^ self next: maxNumberOfElements!
Item was changed:
----- Method: Stream>>take: (in category 'collections - accessing') -----
take: maxNumberOfElements
"See Collection protocol."
+
+ | aCollection |
+ aCollection := OrderedCollection new.
+ maxNumberOfElements timesRepeat: [
+ self atEnd ifTrue: [^ aCollection].
+ aCollection addLast: self next].
+ ^ aCollection!
-
- ^ self any: maxNumberOfElements!