Christoph Thiede uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-ct.1042.mcz
==================== Summary ====================
Name: Collections-ct.1042 Author: ct Time: 2 June 2023, 5:57:00.846658 pm UUID: dbf08d1e-540d-494e-82fa-4ea380f0c3fd Ancestors: Collections-ct.1041
Improves commentary and internal names for HtmlReadWriter permissions. Thanks to Marcel for the feedback!
=============== Diff against Collections-ct.1041 ===============
Item was changed: ----- Method: HtmlReadWriter>>defaultPermissions (in category 'initialize-release') ----- defaultPermissions + "Things that the receiver is allowed or not to do. For instance, clients may restrict network access or code execution through the #shall... accessors."
+ ^ Set with: #downloadResourcesPermission with: #evaluateResourcesPermission! - ^ Set with: #downloadResources with: #evaluateResources!
Item was changed: ----- Method: HtmlReadWriter>>shallDownloadResources (in category 'accessing') ----- shallDownloadResources + "Indicate whether the receiver shall download resources during parsing, such as an image URL in '<img src=""https://squeak.org/static/img/squeak.png%22%22%3E'. May be useful for performance or security concerns." - "Indicate whether the receiver shall download resources during parsing, such as an image URL in "'<img src="https://squeak.org/static/img/squeak.png">'." May be useful for performance or security concerns."
+ ^ self hasPermission: #downloadResourcesPermission! - ^ self hasPermission: #downloadResources!
Item was changed: ----- Method: HtmlReadWriter>>shallDownloadResources: (in category 'accessing') ----- shallDownloadResources: aBoolean + "Set whether the receiver shall download resources during parsing, such as an image URL in '<img src=""https://squeak.org/static/img/squeak.png%22%22%3E'. May be useful for performance or security concerns." - "Set whether the receiver shall download resources during parsing, such as an image URL in "'<img src="https://squeak.org/static/img/squeak.png">'." May be useful for performance or security concerns."
+ ^ self setPermission: #downloadResourcesPermission to: aBoolean! - ^ self setPermission: #downloadResources to: aBoolean!
Item was changed: ----- Method: HtmlReadWriter>>shallEvaluateResources (in category 'accessing') ----- shallEvaluateResources + "Indicate whether the receiver shall evaluate resources during parsing, such as an code URI in '<img src=""code://MenuIcons squeakIcon"">'. May be useful for performance or security concerns." - "Indicate whether the receiver shall evaluate resources during parsing, such as an code URI in "'<img src="code://MenuIcons squeakIcon">'." May be useful for performance or security concerns."
+ ^ self hasPermission: #evaluateResourcesPermission! - ^ self hasPermission: #evaluateResources!
Item was changed: ----- Method: HtmlReadWriter>>shallEvaluateResources: (in category 'accessing') ----- shallEvaluateResources: aBoolean + "Set whether the receiver shall evaluate resources during parsing, such as an code URI in '<img src=""code://MenuIcons squeakIcon"">'. May be useful for performance or security concerns." - "Set whether the receiver shall evaluate resources during parsing, such as an code URI in "'<img src="code://MenuIcons squeakIcon">'." May be useful for performance or security concerns."
+ ^ self setPermission: #evaluateResourcesPermission to: aBoolean! - ^ self setPermission: #evaluateResources to: aBoolean!
Item was changed: (PackageInfo named: 'Collections') postscript: '"Make sure the symbol table consists of immutable sets" #(SymbolTable NewSymbols) do: [ :variableName | (Symbol classPool at: variableName) beReadOnlyObject ].
"Add new instvars to HtmlReadWriter" HtmlReadWriter allSubInstancesDo: [:ea | + (ea instVarNamed: ''permissions'') + ifNil: [ea instVarNamed: ''permissions'' put: ea defaultPermissions] + ifNotNil: [ + ea instVarNamed: ''permissions'' put: + ((ea instVarNamed: ''permissions'') collect: [:sym | (sym , ''Permission'') asSymbol])]. - (ea instVarNamed: ''permissions'') ifNil: [ - ea instVarNamed: ''permissions'' put: ea defaultPermissions]. (ea instVarNamed: ''indent'') ifNil: [ ea instVarNamed: ''indent'' put: 0]. (ea instVarNamed: ''preformattingLevel'') ifNil: [ ea instVarNamed: ''preformattingLevel'' put: (ea breakLines ifTrue: [0] ifFalse: [1])]. (ea instVarNamed: ''exclusionLevel'') ifNil: [ ea instVarNamed: ''exclusionLevel'' put: 0]. (ea instVarNamed: ''lastFixedWhitespace'') ifNil: [ ea instVarNamed: ''lastFixedWhitespace'' put: 0]].'!