[Seaside-dev] more non-portable constructs

[Philippe Marschall]

2008/2/14, Lukas Renggli <renggli at gmail.com>:
> Philippe, did you mark these bugs as fixed on bugs.squeak.org?

No, I can't. I could add comments though.

PHilippe

>  Lukas
>
>
>  On 2/13/08, Philippe Marschall <philippe.marschall at gmail.com> wrote:
>  > 2008/2/12, Paolo Bonzini <bonzini at gnu.org>:
>  > > Two changes I propose:
>  > >
>  > > 1) in WALocale class >> parseCountryString, rewrite it like this:
>  > >
>  > >      | string lines |
>  > >      iso2Countries := Dictionary new.
>  > >      string := self countryList.
>  > >      lines := string findTokens: Character cr.
>  > >          lines allButFirst collect:
>  > >                  [:each |
>  > >                  | parts |
>  > >                  parts := each findTokens: $;.
>  > >                  parts size >= 2 ifTrue: [iso2Countries at: parts second
>  > > put: parts first]]
>  > >      ]
>  > >
>  > > with two changes: a) Using #findTokens: instead of #subStrings: since
>  > > that's what is already in SeasidePlatformSupport; b) Testing that the
>  > > result has two items because in my source the second line of the
>  > > #countryList is blank.
>  >
>  > Thanks, done.
>  >
>  > > 2) in WAEncoder class >> initializeBMP, always pass a parameter to the
>  > > exception handler (currently there is "... on: Error do: [255]").
>  >
>  > Thanks done.
>  >
>  > > Then, here's a small and probably incomplete list of missing
>  > > WAPlatformTest testcases:
>  > >
>  > > 1) SequenceableCollection>>#atRandom
>  > >     SequenceableCollection>>#atRandom:
>  > >     Integer>>#atRandom
>  >
>  > Thanks done, although two of them are only used for tests.
>  >
>  > > 2) Character>>#to: (including running #collect: on the result, because
>  > >     the platform support class should *not* return a String!).
>  >
>  > Done
>  >
>  > > 3) Integer>>#printStringBase:
>  >
>  > Done
>  >
>  > > 4) String>>#padded:to:with:
>  >
>  > Done
>  >
>  > I see you had fun with WAEncoder ;-)
>  >
>  > Cheers
>  > Philippe
>
> > _______________________________________________
>  > seaside-dev mailing list
>  > seaside-dev at lists.squeakfoundation.org
>  > http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>  >
>
>
>
> --
>  Lukas Renggli
>  http://www.lukas-renggli.ch
>
> _______________________________________________
>  seaside-dev mailing list
>  seaside-dev at lists.squeakfoundation.org
>  http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>