[Seaside-dev] WARenderingContext>>#absoluteUrlForResource:

Paolo Bonzini bonzini at gnu.org
Fri Feb 22 10:01:02 UTC 2008


What do you think about rewriting it like this:

absoluteUrlForResource: aString
         <category: 'accessing'>
         | url |
         (aString isNil or: [aString includesSubString: '://']) ifTrue: 
[^aString].
         url := self session application resourceBaseUrl.
         url ifNil: [^aString].
         ^url, aString

With this change, I can fix

     Seaside.WAResourceBaseUrlTest>>#testAbsoluteFtpUrl
     Seaside.WAResourceBaseUrlTest>>#testFileNameWithHttp

The only remaining failure is Seaside.WALocaleTest>>#testLanguageNameIso3

Thanks,

Paolo


More information about the seaside-dev mailing list