[Seaside-dev] WARenderingContext>>#absoluteUrlForResource:

[Philippe Marschall]

Looks good to me, at least better than what we had before.

added in Seaside-Core-pmm.61

Thanks
Philippe

2008/2/22, Paolo Bonzini <bonzini at gnu.org>:
> What do you think about rewriting it like this:
>
>  absoluteUrlForResource: aString
>          <category: 'accessing'>
>          | url |
>          (aString isNil or: [aString includesSubString: '://']) ifTrue:
>  [^aString].
>          url := self session application resourceBaseUrl.
>          url ifNil: [^aString].
>          ^url, aString
>
>  With this change, I can fix
>
>      Seaside.WAResourceBaseUrlTest>>#testAbsoluteFtpUrl
>      Seaside.WAResourceBaseUrlTest>>#testFileNameWithHttp
>
>  The only remaining failure is Seaside.WALocaleTest>>#testLanguageNameIso3
>
>  Thanks,
>
>  Paolo
>  _______________________________________________
>  seaside-dev mailing list
>  seaside-dev at lists.squeakfoundation.org
>  http://lists.squeakfoundation.org/mailman/listinfo/seaside-dev
>