[Seaside-dev] WABrush questionable namings

Gerhard Obermann obi068 at gmail.com
Sun Feb 24 19:23:19 UTC 2008


Hi!

During my trial to create a generic WABrush seaside editor
i have found some questionable namings in WABrush and all subclasses!
Ill hope that some of these could be addressed with Seaside 2.9!
Here is the result after checking mostly all classes:

- WASelectTag
   - #enabled: aBlock <-> #disabled: Boolean .. Its a little bit confusing
to use enabled: in that case

- WATimeInput
 - public api -> public
 - initialize-release -> initialization

- WAAnchorTag
 - conveniance -> convenience
 - #tag -> category accessing

- WAHeadingTag
  - #tag -> category accessing

- WATagBrush
 -#tag -> category accessing

- WAImageTag
 -#tag -> category accessing

- WADivTag
 - public api -> public

- WAFormInputTag: .. why is it necessary to set also the class ?
with: aBlock
 self type isNil ifFalse: [
  self attributes at: 'type' ifAbsentPut: [ self type ].
  self class: self type ].
 super with: aBlock

WATagBrush, WACheckboxTag, WARAdionButtonTag, WASubmitButtonTag
- #canHaveShortcut -> testing

- WACheckboxTag
 #submitFormNamed: -> conveniance (see WAAnchorTag)

- WAButtonTag
 - initialize-release -> initialization

- WAImageButtonTag
 - callback: -> callbacks

- WAFormTag
   - initialize-release -> initialization

- WAGenericTag
  - initialize-release -> initialization

- WAHeadingTag
  - conveniance -> convenience
  - #tag -> accessing

- WAImageTag
   - initialize-release -> initialization
   - #tag -> accessing
Cheers
Gerhard
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/seaside-dev/attachments/20080224/3f4c2856/attachment-0001.htm


More information about the seaside-dev mailing list